[Native] Add debug config for native engine execution #21036
Conversation
There was a problem hiding this comment.
Thans @bikramSingh91 for adding the configs. Looks good to me.
There was a problem hiding this comment.
@bikramSingh91 Thanks.
Please, update commit message to return the following redundant text.
Test Plan:
Updated and added unit tests
| @@ -31,16 +31,31 @@ TEST_F(QueryContextManagerTest, nativeSessionProperties) { | |||
| .systemProperties = { | |||
| {"native_max_spill_level", "1"}, | |||
| {"native_spill_compression_codec", "NONE"}, | |||
| {"native_join_spill_enabled", "true"}, | |||
There was a problem hiding this comment.
Should we move this change to another PR?
There was a problem hiding this comment.
This part is just expanding the unit testing and not changing any defaults so is fairly benign to keep in this PR. Please let me know if you still feel strongly about separating this.
There was a problem hiding this comment.
This is fine. Thanks for clarifying!
There was a problem hiding this comment.
@bikramSingh91 can the Velox advance be moved to another PR?
@majetideepak Please take a look #21039 |
|
@bikramSingh91 can you rebase with master and remove the advance Velox bits? |
This patch adds the required changes to allow setting a debug query config specific to native engine. The query config added on presto side is `native_debug.validate_output_from_operators` Test Plan: Updated and added unit tests
bikramSingh91
force-pushed
the
addDebugFlag
branch
from
045aefc to
b358641
Compare
|
@majetideepak Updated the PR and all tests pass, can you please proceed with the merge |
This patch adds the required changes to allow setting a debug query config
specific to native engine. The query config added on presto side is
native_debug.validate_output_from_operatorsDepends on: #21039 to pull in latest changes from velox