-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable timestamp with time zone type for ddl #21096
Conversation
presto-iceberg/src/main/java/com/facebook/presto/iceberg/IcebergAbstractMetadata.java
Outdated
Show resolved
Hide resolved
@ChunxuTang any comments? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @gupteaj Thanks for the patch.
Re-running the failed tests. |
Since the ICEBERG timestamptz feature is disabled from version 0.285, we are stuck with PrestoDB version 0.284 and unable to upgrade. Instead of disabling this feature, which would break our product upgrades, you could make it an optional feature that users can enable if needed, allowing us to continue with upgrades. |
Description
Presto issue #17891
Motivation and Context
When "timestamp with time zone" type used in create statement for iceberg tables, it maps data type to "timestamp". In this case, data insert and query returns misleading/errors based on timestamp type.
In createColumnIdentity(), iceberg data type for "timestamptz" is retuned as timestamp and then in toPrestoType(), it maps to TIMESTAMP.
Similar issue exists with ALTER TABLE ADD COLUMN case.
presto:test> alter table tab2 add column c1 timestamp with time zone;
Presto should disallow create table and alter table cases. Following column description is misleading to the create statement type.
Impact
create table & alter table statement having "timestamp with time zone" will return error for iceberg tables.
Iceberg column type timestamptz is not supported
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.