Add cost based decision log for scaled writer optimizer #21120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
mlyublena
reviewed
Oct 11, 2023
| @Override | ||
| public Result apply(TableWriterNode node, Captures captures, Context context) | ||
| { | ||
| double taskNumber = context.getStatsProvider().getStats(node).getTableWriterNodeStatsEstimate().getTaskCountIfScaledWriter(); | ||
| statsSource = context.getStatsProvider().getStats(node).getSourceInfo().getSourceInfoName(); |
There was a problem hiding this comment.
since this construct is used several times I wonder if we should introduce a utility function in PlannerUtils:getStatsSource(Context context, PlanNode node)
mlyublena
approved these changes
Oct 11, 2023
pranjalssh
approved these changes
Oct 13, 2023
presto-main/src/main/java/com/facebook/presto/sql/planner/iterative/rule/ScaledWriterRule.java
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/sql/planner/iterative/rule/ScaledWriterRule.java
Outdated
Show resolved
Hide resolved
feilong-liu
force-pushed
the
add_cost_log
branch
from
4269bf3 to
c107d4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#20990 add track of whether an optimization is cost based or not. This PR adds the logging for the new optimizer added in #20901
Motivation and Context
Add logging for new optimizer.
Impact
Make log to be consistent.
Test Plan
Easy change.
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.