-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support indicating partition transform when add column to Iceberg table #21206
Support indicating partition transform when add column to Iceberg table #21206
Conversation
Codenotify: Notifying subscribers in CODENOTIFY files for diff 82a3bc8...3db9205.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working well for me! Nice work. I have two small comments about the docs below
b6c19be
to
523bcc2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! I appreciate your attention to accurate formatting of the code.
I made a few style and revision suggestions, and I explained my thoughts in the comments. If my suggested edits change the meaning of your text in a way you disagree with, let me know if I overlooked your intended meaning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two questions, otherwise PR looks good!
presto-iceberg/src/test/java/com/facebook/presto/iceberg/IcebergDistributedTestBase.java
Show resolved
Hide resolved
presto-iceberg/src/test/java/com/facebook/presto/iceberg/IcebergDistributedTestBase.java
Show resolved
Hide resolved
9e5a64e
to
79ab64a
Compare
Co-authored-by: Steve Burnett <[email protected]>
0aa06b2
to
3db9205
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (docs)
Local build of docs, everything looks good.
Description
Through this PR, when we alter an Iceberg table to add a new column, we could also indicate it as a partition column. Moreover, we could use the
transform
functions and partition the table by the transformed value of the column, for example:ALTER TABLE iceberg.web.page_views ADD COLUMN zipcode VARCHAR WITH (partitioning = 'identity');
ALTER TABLE iceberg.web.page_views ADD COLUMN location VARCHAR WITH (partitioning = 'truncate(2)');
ALTER TABLE iceberg.web.page_views ADD COLUMN location VARCHAR WITH (partitioning = 'bucket(8)');
Note:
Day
,Month
,Year
,Hour
partition column transform functions are not supported in Presto Iceberg connector yet.Test Plan
Contributor checklist
Release Notes