Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Joda-Time to 2.12.5 #21329

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

yhwang
Copy link
Member

@yhwang yhwang commented Nov 7, 2023

Description

Update Joda-Time from 2.12.2 to 2.12.5. The tzdata version is upgraded from 2022g to 2023c and the changes are:

  • Lebanon delays the start of DST in 2023
  • Egypt now uses DST again, from April through October
  • In 2023, Morocco springs forward April 23, not April 30
  • Palestine delays the start of DST in 2023
  • Much of Greenland still uses DST from 2024 on
  • America/Yellowknife now links to America/Edmonton

There is no new time zone, only new DST rules.

Motivation and Context

fix: #21300

Impact

The update only introduces new DST rules but no new time zone.

Test Plan

Leverage the existing timezone test cases to make sure no regression

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* Update Joda-Time to 2.12.5 to use 2023c tzdata.
  Note: a corresponding update to the Java runtime should also be made to ensure consistent timezone data.
  For example, Oracle JDK 8u381, tzdata-java-2023c rpm for OpenJDK, or use Timezone Updater Tool to apply
  2023c tzdata to existing JVM.

Update Joda-Time from 2.12.2 to 2.12.5. The tzdata version is upgraded
from  2022g to 2023c and the changes are:
- Lebanon delays the start of DST in 2023
- Egypt now uses DST again, from April through October
- In 2023, Morocco springs forward April 23, not April 30
- Palestine delays the start of DST in 2023
- Much of Greenland still uses DST from 2024 on
- America/Yellowknife now links to America/Edmonton

There is no new time zone, only new DST rules.

Signed-off-by: Yihong Wang <[email protected]>
@yhwang yhwang requested a review from a team as a code owner November 7, 2023 04:44
@yhwang yhwang requested a review from presto-oss November 7, 2023 04:44
@yhwang
Copy link
Member Author

yhwang commented Nov 7, 2023

No new test case is added and I manually verified Africa/Cairo's new DST rule:
Cairo DST: April 28, 2023 to October 27, 2023

With DST:

presto:sf1> SELECT DATE_DIFF( 'hour', CAST('2023-9-30 12:00:00.000 Africa/Cairo' as timestamp with time zone), CAST('2023-9-30 12:00:00.000 UTC' as timestamp with time zone)) as "hours";
 hours
-------
     3
(1 row)

No DST:

presto:sf1> SELECT DATE_DIFF( 'hour', CAST('2023-10-30 12:00:00.000 Africa/Cairo' as timestamp with time zone), CAST('2023-10-30 12:00:00.000 UTC' as timestamp with time zone)) as "hours";
 hours
-------
     2
(1 row)

@tdcmeehan tdcmeehan merged commit d35917c into prestodb:master Nov 8, 2023
@yhwang yhwang deleted the update-joda-time-version branch November 8, 2023 21:11
@wanglinsong wanglinsong mentioned this pull request Dec 8, 2023
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update joda-time to 2.12.5
2 participants