Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix High Memory Task Killer to kill highest memory consuming query #21349

Merged

Conversation

swapsmagic
Copy link
Contributor

Description

Fix High Memory Task Killer to return highest memory consuming query. Currently it's killing the lowest memory consuming query.

Test Plan

Unit test.

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* Fix High Memory Task killer to kill highest memory consuming query

@swapsmagic swapsmagic requested a review from a team as a code owner November 9, 2023 04:48
@swapsmagic swapsmagic requested a review from presto-oss November 9, 2023 04:48
Fix High Memory Task Killer to return highest memory consuming query.
@swapsmagic swapsmagic force-pushed the fix_high_memory_task_killer_new branch from ad39578 to 0970a2a Compare November 9, 2023 07:08
Copy link
Contributor

@ajaygeorge ajaygeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swapsmagic swapsmagic merged commit 8282585 into prestodb:master Nov 9, 2023
@swapsmagic swapsmagic deleted the fix_high_memory_task_killer_new branch November 9, 2023 16:57
@wanglinsong wanglinsong mentioned this pull request Dec 8, 2023
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants