Add release notes for 0.285 #21579

majetideepak · 2023-12-20T09:46:54Z

No description provided.

majetideepak · 2023-12-20T09:49:07Z

presto-docs/src/main/sphinx/release/release-0.285.rst

+
+Security Changes
+________________
+* Fix critical vulnerability in Babel and related npm packages by updating to newer versions. :pr:`21322`


@tdcmeehan I felt it is easier to read the release notes if we keep them brief and include a link to the PR or the doc for the feature.
Any thoughts?

I think this is a good idea to keep the note concise, while allowing people to dig deeper.

github-actions · 2023-12-20T13:06:12Z

Codenotify: Notifying subscribers in CODENOTIFY files for diff ec51f52...760b684.

Notify	File(s)
@steveburnett	presto-docs/src/main/sphinx/release.rst presto-docs/src/main/sphinx/release/release-0.285.rst

majetideepak · 2023-12-20T16:24:04Z

self comment: Add release note for #21578

wanglinsong · 2023-12-20T18:51:55Z

presto-docs/src/main/sphinx/release/release-0.284.rst

 * Fix directory listing over directories with content-type ``application/octet-stream`` (:issue:`20310`).
 * Add DWRF filetype to min, max filtering for special column types such as tinyint, varbinary and timestamp.

 Iceberg Connector Changes
-_______________
+_________________________


Please exclude 0.284. No need to update.

wanglinsong · 2023-12-20T18:53:16Z

Ref: #21500

steveburnett

I made some suggestions adding PR links, links to docs, or both, where I thought they would benefit the reader.
Suggested some revisions of individual release note entries based on the wording in the Order of changes in the Release Note Guidelines.

A structure comment: I suggest rearranging the sections to follow the sequence presented in the Order of sections in the Release Note Guidelines.

Note: "Documentation" is not currently a section heading in the Order of sections. Suggest remove the heading and collapse the docs entries into General Changes, or we consider updating the Order of Sections.

presto-docs/src/main/sphinx/release/release-0.285.rst

majetideepak · 2024-01-03T20:49:02Z

@steveburnett thanks for sharing Order of Changes. I followed that document and made some more changes. Please take another look.

steveburnett

Thanks for the changes! I found three nits that surfaced as part of the suggested changes from the first review, but there's nothing else.

Did a local build of docs, reviewed the page as built. Also tested and verified that all links to PRs and docs work and link to the indicated destination.

presto-docs/src/main/sphinx/release/release-0.285.rst

steveburnett

LGTM! (docs)

Did a local build of docs and reviewed the page as built. Tested and verified that all links to PRs and docs work, and link to the indicated destination.

tdcmeehan

High level, release notes should be understandable to end users of Presto--i.e., operators. The audience is not DB developers, they're data engineers and people who have very little time to parse and understand the release notes content. It needs to be concise and understandable to lay people.

tdcmeehan · 2024-01-04T00:58:30Z

presto-docs/src/main/sphinx/release/release-0.285.rst

+* Improve latency of HBO. :pr:`21297`
+* Improve HBO to track partial aggregation statistics. :pr:`21160`
+* Improve PushPartialAggregationThroughExchange to use partial aggregation statistics when available. This extends to multi-key aggregations.
+* Improve union node by removing the empty inputs.


Suggested change

* Improve union node by removing the empty inputs.

* Improve performance of union when subqueries are empty.

tdcmeehan · 2024-01-04T00:59:07Z

presto-docs/src/main/sphinx/release/release-0.285.rst

+_______________
+* Fix `min_by(x, y, n) / max_by(x, y, n)` functions to ensure `n` is unique.
+* Fix LIKE pattern to handle multi-byte characters. :pr:`21578`
+* Improve latency of HBO. :pr:`21297`


Suggested change

* Improve latency of HBO. :pr:`21297`

* Improve latency of HBO. :pr:`21297`, :pr:`21308`

tdcmeehan · 2024-01-04T00:59:15Z

presto-docs/src/main/sphinx/release/release-0.285.rst

+* Improve HBO to track partial aggregation statistics. :pr:`21160`
+* Improve PushPartialAggregationThroughExchange to use partial aggregation statistics when available. This extends to multi-key aggregations.
+* Improve union node by removing the empty inputs.
+* Improve HBO latency by skipping retry if it times out. :pr:`21308`


Suggested change

* Improve HBO latency by skipping retry if it times out. :pr:`21308`

tdcmeehan · 2024-01-04T01:00:24Z

presto-docs/src/main/sphinx/release/release-0.285.rst

+* Improve PushPartialAggregationThroughExchange to use partial aggregation statistics when available. This extends to multi-key aggregations.
+* Improve union node by removing the empty inputs.
+* Improve HBO latency by skipping retry if it times out. :pr:`21308`
+* Improve join-reordering to work with non-simple equi-join predicates.


Suggested change

* Improve join-reordering to work with non-simple equi-join predicates.

* Improve cost based optimizer join reordering to work with ....

Any suggestions on how to make "non-simple equijoin predicates" a little bit more understandable?

Probably a link to the PR will help.

CC: @aaneja for input.

How about - Improve join reordering for complex equi-join clauses PR : #21153

complex is slightly better than non-simple but I believe a Presto user is better off looking at the PR for the actual improvement. I don't think there is an easy wording to describe the change here.

tdcmeehan · 2024-01-04T01:00:40Z

presto-docs/src/main/sphinx/release/release-0.285.rst

+* Improve union node by removing the empty inputs.
+* Improve HBO latency by skipping retry if it times out. :pr:`21308`
+* Improve join-reordering to work with non-simple equi-join predicates.
+* Improve :doc:`REST API</rest>` documentation by providing links.


Suggested change

* Improve :doc:`REST API</rest>` documentation by providing links.

Just a docs update, can omit.

tdcmeehan · 2024-01-04T01:02:28Z

presto-docs/src/main/sphinx/release/release-0.285.rst

+* Add a session property ``history_input_table_statistics_matching_threshold`` to set the threshold for input statistics match in HBO. :pr:`21063`
+* Add a session property ``remove_redundant_cast_to_varchar_in_join`` (enabled by default) to remove redundant `cast to varchar` expressions in a join condition. :pr:`21050`
+* Add a session property ``enable_hbo_for_scaled_writer`` (disabled by default) to use HBO for scaled writers.
+* Add a session property ``use_partial_aggregation_history`` if partial aggregation statistics must be used to split aggregates into partial and final. :pr:`21160`


Let's word it like:

Feature -> this feature is configurable by session property X (enabled/disabled by default)

tdcmeehan · 2024-01-04T01:03:03Z

presto-docs/src/main/sphinx/release/release-0.285.rst

+* Add a session property ``remove_redundant_cast_to_varchar_in_join`` (enabled by default) to remove redundant `cast to varchar` expressions in a join condition. :pr:`21050`
+* Add a session property ``enable_hbo_for_scaled_writer`` (disabled by default) to use HBO for scaled writers.
+* Add a session property ``use_partial_aggregation_history`` if partial aggregation statistics must be used to split aggregates into partial and final. :pr:`21160`
+* Add a config property ``task.memory-based-slowdown-threshold`` that provides a heap memory threshold below which new splits are not processed. :pr:`20946`


This feature is experimental and dangerous, I do not recommend adding it to the release notes.

tdcmeehan · 2024-01-04T01:03:48Z

presto-docs/src/main/sphinx/release/release-0.285.rst

+* Add tracking of null probe keys in join and use it to enable outer join null salt in history-based optimization. :pr:`21203`
+* Add optimization where values node followed by an always false filter is converted to an empty values node.
+* Add information about cost-based optimizers and the source of stats they use (CBO/HBO) in explain plans when session property ``verbose_optimizer_info_enabled=true``. :pr:`20990`
+* Add a boolean to the PlanOptimizer's return value to indicate if an optimization has been triggered.


This is not a user facing change, can remove

tdcmeehan · 2024-01-04T01:04:04Z

presto-docs/src/main/sphinx/release/release-0.285.rst

+* Add optimization where values node followed by an always false filter is converted to an empty values node.
+* Add information about cost-based optimizers and the source of stats they use (CBO/HBO) in explain plans when session property ``verbose_optimizer_info_enabled=true``. :pr:`20990`
+* Add a boolean to the PlanOptimizer's return value to indicate if an optimization has been triggered.
+* Rename config ``experiemental.task.high-memory-task-killer-strategy`` to ``experimental.task.high-memory-task-killer-strategy``.


Per above, let's just remove it altogether

tdcmeehan · 2024-01-04T01:06:20Z

presto-docs/src/main/sphinx/release/release-0.285.rst

+* Add a session property ``enable_hbo_for_scaled_writer`` (disabled by default) to use HBO for scaled writers.
+* Add a session property ``use_partial_aggregation_history`` if partial aggregation statistics must be used to split aggregates into partial and final. :pr:`21160`
+* Add a config property ``task.memory-based-slowdown-threshold`` that provides a heap memory threshold below which new splits are not processed. :pr:`20946`
+* Add tracking of null probe keys in join and use it to enable outer join null salt in history-based optimization. :pr:`21203`


This needs to be more understandable for a user.

Suggested change

* Add tracking of null probe keys in join and use it to enable outer join null salt in history-based optimization. :pr:`21203`

* Improve history based optimizer performance when nulls are present in joins. :pr:`21203`

tdcmeehan

LGTM. Thank you for linking the PRs, I find this very useful to keep the release note concise, while also giving more technical people a way to understand more details.

github-actions bot added the docs label Dec 20, 2023

majetideepak commented Dec 20, 2023

View reviewed changes

majetideepak force-pushed the release-notes-285 branch from 9abab12 to c47e557 Compare December 20, 2023 13:04

majetideepak marked this pull request as ready for review December 20, 2023 13:05

majetideepak requested a review from a team as a code owner December 20, 2023 13:05

majetideepak requested a review from presto-oss December 20, 2023 13:05

majetideepak requested a review from steveburnett December 20, 2023 13:07

majetideepak force-pushed the release-notes-285 branch from c47e557 to 07e8376 Compare December 20, 2023 13:09

tdcmeehan self-assigned this Dec 20, 2023

wanglinsong reviewed Dec 20, 2023

View reviewed changes

tdcmeehan mentioned this pull request Dec 22, 2023

Add release notes for 0.285 #21500

Closed

26 tasks

wanglinsong mentioned this pull request Dec 30, 2023

Presto release 0.285.1 #21597

Closed

steveburnett requested changes Jan 3, 2024

View reviewed changes

majetideepak force-pushed the release-notes-285 branch from 07e8376 to 4489094 Compare January 3, 2024 20:47

steveburnett requested changes Jan 3, 2024

View reviewed changes

majetideepak force-pushed the release-notes-285 branch from 4489094 to 6a3e381 Compare January 3, 2024 22:14

steveburnett approved these changes Jan 3, 2024

View reviewed changes

tdcmeehan requested changes Jan 4, 2024

View reviewed changes

Add release notes for 0.285

760b684

majetideepak force-pushed the release-notes-285 branch from 6a3e381 to 760b684 Compare January 4, 2024 02:10

tdcmeehan approved these changes Jan 4, 2024

View reviewed changes

wanglinsong merged commit 9af4347 into prestodb:master Jan 4, 2024
57 checks passed

majetideepak deleted the release-notes-285 branch February 2, 2024 16:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add release notes for 0.285 #21579

Add release notes for 0.285 #21579

majetideepak commented Dec 20, 2023 •

edited

Loading

majetideepak Dec 20, 2023 •

edited

Loading

tdcmeehan Dec 22, 2023

github-actions bot commented Dec 20, 2023 •

edited

Loading

majetideepak commented Dec 20, 2023

wanglinsong Dec 20, 2023

majetideepak Jan 3, 2024

wanglinsong commented Dec 20, 2023

steveburnett left a comment

majetideepak commented Jan 3, 2024

steveburnett left a comment

steveburnett left a comment

tdcmeehan left a comment

tdcmeehan Jan 4, 2024

tdcmeehan Jan 4, 2024

tdcmeehan Jan 4, 2024

tdcmeehan Jan 4, 2024

majetideepak Jan 4, 2024

majetideepak Jan 4, 2024

aaneja Jan 4, 2024

majetideepak Jan 4, 2024 •

edited

Loading

tdcmeehan Jan 4, 2024

tdcmeehan Jan 4, 2024

tdcmeehan Jan 4, 2024

tdcmeehan Jan 4, 2024

tdcmeehan Jan 4, 2024

tdcmeehan Jan 4, 2024

tdcmeehan left a comment

	* Improve union node by removing the empty inputs.
	* Improve performance of union when subqueries are empty.

	* Improve latency of HBO. :pr:`21297`
	* Improve latency of HBO. :pr:`21297`, :pr:`21308`

	* Improve join-reordering to work with non-simple equi-join predicates.
	* Improve cost based optimizer join reordering to work with ....

	* Add tracking of null probe keys in join and use it to enable outer join null salt in history-based optimization. :pr:`21203`
	* Improve history based optimizer performance when nulls are present in joins. :pr:`21203`

Add release notes for 0.285 #21579

Add release notes for 0.285 #21579

Conversation

majetideepak commented Dec 20, 2023 • edited Loading

majetideepak Dec 20, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Dec 20, 2023 • edited Loading

majetideepak commented Dec 20, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wanglinsong commented Dec 20, 2023

steveburnett left a comment

Choose a reason for hiding this comment

majetideepak commented Jan 3, 2024

steveburnett left a comment

Choose a reason for hiding this comment

steveburnett left a comment

Choose a reason for hiding this comment

tdcmeehan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

majetideepak Jan 4, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tdcmeehan left a comment

Choose a reason for hiding this comment

majetideepak commented Dec 20, 2023 •

edited

Loading

majetideepak Dec 20, 2023 •

edited

Loading

github-actions bot commented Dec 20, 2023 •

edited

Loading

majetideepak Jan 4, 2024 •

edited

Loading