Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for iceberg set properties #21606

Closed

Conversation

pratyakshsharma
Copy link
Contributor

@pratyakshsharma pratyakshsharma commented Dec 27, 2023

Description

Add support for Iceberg ALTER TABLE SET PROPERTIES
Needs to merge after #21495 and #21250.

Docs and testing is pending.

Motivation and Context

#21251

Impact

ALTER TABLE foo SET PROPERTIES (commit_retries = 5);

Test Plan

Unit testing (pending) and manual testing (done)

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

Iceberg Changes
* Add implementation for ALTER TABLE SET PROPERTIES command

@pratyakshsharma pratyakshsharma requested a review from a team as a code owner December 27, 2023 16:13
Copy link

github-actions bot commented Dec 27, 2023

Codenotify: Notifying subscribers in CODENOTIFY files for diff 0f89633...ba42733.

Notify File(s)
@aditi-pandit presto-parser/src/main/antlr4/com/facebook/presto/sql/parser/SqlBase.g4
@elharo presto-parser/src/main/antlr4/com/facebook/presto/sql/parser/SqlBase.g4
@kaikalur presto-parser/src/main/antlr4/com/facebook/presto/sql/parser/SqlBase.g4
@rschlussel presto-parser/src/main/antlr4/com/facebook/presto/sql/parser/SqlBase.g4
@steveburnett presto-docs/src/main/sphinx/connector/iceberg.rst
presto-docs/src/main/sphinx/sql/alter-table.rst

@pratyakshsharma pratyakshsharma marked this pull request as draft December 27, 2023 16:16
@pratyakshsharma pratyakshsharma marked this pull request as ready for review December 28, 2023 14:46
@pratyakshsharma
Copy link
Contributor Author

Please do not review it for now, it needs to merge after #21495 and #21250.

Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the doc! A couple of small suggestions - if they don't look good to you, let me know and we'll figure it out.

@yingsu00 yingsu00 self-requested a review January 4, 2024 05:21
@pratyakshsharma
Copy link
Contributor Author

Thank you for your review @steveburnett . I am closing the PR and these changes are now added to #21495 as a separate commit. I have addressed your review comments there itself.
Please have a look and let us continue the discussion there.
cc @yingsu00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants