[codemod] Remove unused-variable in /fbcode/github/presto-trunk/presto-native-execution/presto_cpp/main/QueryContextManager.cpp #23960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o-native-execution/presto_cpp/main/QueryContextManager.cpp
Summary:
[codemod] Remove unused-variable in {filename}
LLVM-15 has a warning `-Wunused-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.
This diff either (a) removes an unused variable and, possibly, it's associated code or (b) qualifies the variable with `[[maybe_unused]]`.
#buildsonlynotests - Builds are sufficient to verify
- If you approve of this diff, please use the "Accept & Ship" button :-)
Differential Revision: D65445391
|
This pull request was exported from Phabricator. Differential Revision: D65445391 |
amitkdutta
approved these changes
Nov 7, 2024
This was referenced Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
[codemod] Remove unused-variable in {filename}
LLVM-15 has a warning
-Wunused-variablewhich we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.This diff either (a) removes an unused variable and, possibly, it's associated code or (b) qualifies the variable with
[[maybe_unused]].#buildsonlynotests - Builds are sufficient to verify
Differential Revision: D65445391