Upgrade netty dependencies to address CVE-2024-47535 #24137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestodb-ci
requested review from
a team,
aaneja and
zuyu
and removed request for
a team
infvg
force-pushed
the
netty-upgrade
branch
2 times, most recently
from
9687bae to
cfcc15d
Compare
infvg
force-pushed
the
netty-upgrade
branch
3 times, most recently
from
583c49d to
2d45ed7
Compare
jaystarshot
previously approved these changes
Dec 2, 2024
aaneja
previously approved these changes
Dec 3, 2024
Upgrade the netty dependencies to resolve CVE-2024-47535 If implemented this will: Upgrade the netty dependencies to 4.1.115.Final
jaystarshot
reviewed
Dec 3, 2024
| @@ -209,10 +210,12 @@ | |||
| <dependencies> | |||
| <dependency> | |||
| <groupId>io.netty</groupId> | |||
| <artifactId>netty-handler</artifactId> | |||
| <version>4.1.107.Final</version> | |||
| <artifactId>netty-bom</artifactId> | |||
There was a problem hiding this comment.
why did the artifact id change? Maybe netty is not used at all?
There was a problem hiding this comment.
several different netty dependencies are being used. Only netty-handler's version is being overrided (although all of them should be the same version). I've replaced this with the netty-bom to synchronize all netty dependencies to that version.
jaystarshot
approved these changes
Dec 4, 2024
|
LG! |
tdcmeehan
approved these changes
Dec 9, 2024
This was referenced Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade the netty dependencies to CVE-2024-47535
If implemented this will:
Upgrade the netty dependencies to 4.1.115.Final
Motivation and Context
This upgrade was created to deal with CVEs found in lower versions
Impact
None
Release Notes