Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use alluxio-core instead of shaded deps to get rid of CVEs #24231

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

denodo-research-labs
Copy link
Contributor

@denodo-research-labs denodo-research-labs commented Dec 10, 2024

Description

Replace alluxio-shaded-client by alluxio-core-client-hdfs, alluxio-core-client-fs and alluxio-core-common.
This change fixes the following Critical and HIGH CVEs introduced by alluxio-shaded-client v313:

CRITICAL

HIGH

The following dependencies need to be upgraded due to this change:

  • errorprone 2.28.0
  • commons-lang3 3.14.0
  • gson 2.11.0
  • httpclient 4.5.14
  • httpcore 4.4.16
  • guice 5.1.0, this change forces the exclusion of guice-multibindings from some libraries that depend on earlier versions of Guice, since guice-multibindings has been moved to guice-core v4.2.

Motivation and Context

Using the alluxio-core libraries instead of the shaded version prevents a lot of CVEs of Critical and HIGH severity.
In general, the shaded versions should be avoided for this reason.

Contributor checklist

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

Security Changes
* Replace `alluxio-shaded-client` with `alluxio-core` libraries libraries in response to `CVE-2023-44981
 <https://github.com/advisories/GHSA-7286-pgfv-vxvh>`_. :pr:`24231`

Copy link
Contributor

@ZacBlanco ZacBlanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one question

presto-hive-hadoop2/pom.xml Show resolved Hide resolved
Copy link
Contributor

@ZacBlanco ZacBlanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit, otherwise looks good

presto-cache/pom.xml Outdated Show resolved Hide resolved
ZacBlanco
ZacBlanco previously approved these changes Dec 13, 2024
@infvg
Copy link
Contributor

infvg commented Jan 2, 2025

Tested in IBM lakehouse successfully
image

@steveburnett
Copy link
Contributor

Suggest including at least the critical CVE in the release note for visibility. This suggestion would look like this:

== RELEASE NOTES ==

Security Changes
* Replace `alluxio-shaded-client` with `alluxio-core` libraries in response to `CVE-2023-44981
 <https://github.com/advisories/GHSA-7286-pgfv-vxvh>`_. :pr:`24231`

Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't find any documentation to review.

@denodo-research-labs
Copy link
Contributor Author

@ZacBlanco, could you review again, please? We just merged the conflicting changes.

Failing checks in test other modules are due to #24334.
And the ones from prestocpp: No space left on device and ld: library 'velox_dwio_arrow_parquet_writer_lib' not found

ZacBlanco
ZacBlanco previously approved these changes Jan 8, 2025
@denodo-research-labs
Copy link
Contributor Author

@tdcmeehan, any possibility of merging it?

tdcmeehan
tdcmeehan previously approved these changes Jan 8, 2025
@denodo-research-labs
Copy link
Contributor Author

denodo-research-labs commented Jan 9, 2025

Could someone run test (:presto-spark-base -P presto-spark-tests-smoke) again, please?
It is running successfully in our local environment.

@denodo-research-labs
Copy link
Contributor Author

Could it be merged now? The prestocpp errors are due to No space left on the device and ld: library 'velox_dwio_arrow_parquet_writer_lib' not found

@tdcmeehan
Copy link
Contributor

@denodo-research-labs can you please rebase to fix the flaky C++ tests above?

@denodo-research-labs denodo-research-labs force-pushed the cve_alluxio_shaded branch 2 times, most recently from 4ad0677 to 4122ea1 Compare January 16, 2025 09:00
@denodo-research-labs
Copy link
Contributor Author

denodo-research-labs commented Jan 20, 2025

@tdcmeehan tdcmeehan merged commit b1d4e22 into prestodb:master Jan 23, 2025
59 checks passed
shangm2 pushed a commit to shangm2/presto that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants