-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use alluxio-core instead of shaded deps to get rid of CVEs #24231
Use alluxio-core instead of shaded deps to get rid of CVEs #24231
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one question
9b2ed60
to
932d013
Compare
6fad246
to
6816244
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nit, otherwise looks good
6816244
to
839a27d
Compare
Suggest including at least the critical CVE in the release note for visibility. This suggestion would look like this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't find any documentation to review.
1926a63
to
9fd2878
Compare
@ZacBlanco, could you review again, please? We just merged the conflicting changes. Failing checks in |
@tdcmeehan, any possibility of merging it? |
b81a8d5
9fd2878
to
b81a8d5
Compare
Could someone run |
Could it be merged now? The prestocpp errors are due to |
@denodo-research-labs can you please rebase to fix the flaky C++ tests above? |
4ad0677
to
4122ea1
Compare
4122ea1
to
ef35c12
Compare
ef35c12
to
73ec774
Compare
|
Description
Replace
alluxio-shaded-client
byalluxio-core-client-hdfs
,alluxio-core-client-fs
andalluxio-core-common
.This change fixes the following Critical and HIGH CVEs introduced by
alluxio-shaded-client v313
:CRITICAL
HIGH
The following dependencies need to be upgraded due to this change:
guice-multibindings
from some libraries that depend on earlier versions of Guice, sinceguice-multibindings
has been moved toguice-core
v4.2.Motivation and Context
Using the
alluxio-core
libraries instead of the shaded version prevents a lot of CVEs of Critical and HIGH severity.In general, the shaded versions should be avoided for this reason.
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.