[native] Fix unsafe row exchange source with compression support #24291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gggrace14
previously approved these changes
Dec 20, 2024
xiaoxmeng
force-pushed
the
unsafe
branch
2 times, most recently
from
5556efc to
cf0c679
Compare
gggrace14
previously approved these changes
Dec 20, 2024
kagamiori
previously approved these changes
Dec 20, 2024
tanjialiang
previously approved these changes
Dec 20, 2024
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Looks like |
xiaoxmeng
dismissed stale reviews from gggrace14, tanjialiang, and kagamiori
via
ea7ceec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Velox has added compression support for row format but the unsaferow exchange source
built for Sapphire on Velox only expect concatenated serialized rows. This PR fixes this
by adding a uncompressed row group header to make the serialized format compatible.