Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility of removing DWRF #24315

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

namya28
Copy link
Contributor

@namya28 namya28 commented Jan 2, 2025

Description

This PR is for checking the possibility of removing DWRF.

Motivation and Context

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* ... :pr:`12345`
* ... :pr:`12345`

Hive Connector Changes
* ... :pr:`12345`
* ... :pr:`12345`

If release note is NOT required, use:

== NO RELEASE NOTE ==

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Jan 2, 2025
@prestodb-ci prestodb-ci requested review from a team, nishithakbhaskaran and jp-sivaprasad and removed request for a team January 2, 2025 10:49
@namya28 namya28 requested a review from imjalpreet January 2, 2025 10:49
@namya28 namya28 changed the title Removing hive-dwrf Removing dwrf Jan 2, 2025
@namya28 namya28 changed the title Removing dwrf Removing DWRF Jan 2, 2025
@aditi-pandit
Copy link
Contributor

@namya28 : What is the motivation for this change ? Am curious as Dwrf format is used heavily on C++ side. Parquet, ORC and others are still in very active development on the Native engine, so having Dwrf helps especially for testing features independent of the file format.

@namya28 namya28 changed the title Removing DWRF Possibility of removing DWRF Jan 3, 2025
@namya28
Copy link
Contributor Author

namya28 commented Jan 3, 2025

@namya28 : What is the motivation for this change ? Am curious as Dwrf format is used heavily on C++ side. Parquet, ORC and others are still in very active development on the Native engine, so having Dwrf helps especially for testing features independent of the file format.

Hi @aditi-pandit , thank you for sharing your thoughts. I was actually working on a cve fix for snappy 0.2 jar . This was coming transitively from hive-dwrf. As per discussion with @tdcmeehan , I was advised to work on the possibility of removing dwrf. However this work is still in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:IBM PR from IBM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants