Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native] Respect summarize flag in TaskResource #24369

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

arhimondr
Copy link
Member

@arhimondr arhimondr commented Jan 15, 2025

Description

When summarize flag is set do not send detailed per-pipeline stats (same as in Java implementation) to save CPU on serialization / deserialization

Motivation and Context

A significantly higher CPU utilization on coordinator for native workers is observed due to ignored "summarize" flag.

Impact

Lower CPU utilization and GC activity on coordinator for Prestissimo deployments

Test Plan

Unit test

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* Improve coordinator task management performance. :pr:`24369`

When summarize flag is set do not send detailed per-pipeline stats (same
as in Java implementation) to save CPU on serialization /
deserialization

Co-authored-by: Andrii Rosa <[email protected]>
@arhimondr arhimondr requested a review from a team as a code owner January 15, 2025 17:51
@prestodb-ci prestodb-ci added the from:Meta PR from Meta label Jan 15, 2025
@arhimondr arhimondr requested a review from amitkdutta January 15, 2025 17:52
Copy link
Contributor

@amitkdutta amitkdutta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @arhimondr

@amitkdutta amitkdutta merged commit 1b57e1c into prestodb:master Jan 15, 2025
58 of 59 checks passed
@arhimondr arhimondr deleted the prestissimo_summarize branch January 15, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:Meta PR from Meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants