Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[native] Deprecate query level cache config #24372

Merged
merged 1 commit into from
Jan 16, 2025
Merged

[native] Deprecate query level cache config #24372

merged 1 commit into from
Jan 16, 2025

Conversation

zacw7
Copy link
Member

@zacw7 zacw7 commented Jan 16, 2025 •
edited
Loading 

== RELEASE NOTES ==

General Changes
* Remove ``query-data-cache-enabled-default`` configuration property, which is no longer needed as per-split fine-grained cache control has been introduced. :pr:`24372 `

@zacw7 zacw7 requested review from steveburnett, elharo and a team as code owners January 16, 2025 02:37
@zacw7 zacw7 requested a review from presto-oss January 16, 2025 02:37
@prestodb-ci prestodb-ci added the from:Meta PR from Meta label Jan 16, 2025
@zacw7 zacw7 requested a review from kewang1024 January 16, 2025 02:37
xiaoxmeng
xiaoxmeng approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@xiaoxmeng xiaoxmeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zacw7 thanks!

steveburnett
steveburnett approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull branch, local doc build, looks good. Thanks!

@zacw7 zacw7 merged commit fa090fc into prestodb:master Jan 16, 2025
59 of 60 checks passed
@zacw7 zacw7 deleted the query-level-cache branch January 16, 2025 18:25
This was referenced Jan 28, 2025
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveburnett steveburnett steveburnett approved these changes

@xiaoxmeng xiaoxmeng xiaoxmeng approved these changes

@elharo elharo Awaiting requested review from elharo elharo is a code owner

@presto-oss presto-oss Awaiting requested review from presto-oss presto-oss is a code owner automatically assigned from prestodb/committers

@kewang1024 kewang1024 Awaiting requested review from kewang1024

Assignees
No one assigned
Labels
from:Meta PR from Meta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zacw7 @steveburnett @xiaoxmeng @prestodb-ci