[Iceberg] Add manifest file caching for HMS-based deployments #24481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZacBlanco
force-pushed
the
upstream-iceberg-manifest-caching
branch
from
7db7896 to
666d248
Compare
jaystarshot
reviewed
Feb 6, 2025
| @@ -67,7 +67,7 @@ public class IcebergConfig | |||
|
|
|||
| private EnumSet<ColumnStatisticType> hiveStatisticsMergeFlags = EnumSet.noneOf(ColumnStatisticType.class); | |||
| private String fileIOImpl = HadoopFileIO.class.getName(); | |||
| private boolean manifestCachingEnabled; | |||
| private boolean manifestCachingEnabled = true; | |||
There was a problem hiding this comment.
Yes this is intentional. Performance is significantly worse with it disabled, and I don't think there are any known downsides to making this enabled by default other than an increased memory footprint
jaystarshot
reviewed
Feb 6, 2025
| public ManifestFileCache createManifestFileCache(IcebergConfig config, MBeanExporter exporter) | ||
| { | ||
| Cache<ManifestFileCacheKey, ManifestFileCachedContent> delegate = CacheBuilder.newBuilder() | ||
| .maximumWeight(config.getManifestCachingEnabled() ? config.getMaxManifestCacheSize() : 0) |
There was a problem hiding this comment.
If the caching is disabled i think we should not have any caching instead of adding this via 0 weight
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds manifest file caching to the Iceberg connector for HMS-based deployments.
Motivation and Context
In order to optimize and plan iceberg queries we call the
planFiles()API multiple times throughout the query optimization lifecycle. Each time it requires reading and parsing metadata files which usually exist on an external filesystem such as S3. For large tables there could be hundreds of files. They usually range in a few kilobytes in size up to a few megabytes. When not cached in memory within Presto it can lead to significant E2E query latency degradation.Impact
TBD
Test Plan
TBD
Contributor checklist
Release Notes