-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Update Presto version in example in installation/cli.rst #24491
Conversation
7cd75de
to
4a7b425
Compare
4a7b425
to
1a80f10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
However, should we mention that it's important to have only one CLI JAR file in the current directory, since we're using the *
wildcard now. If there are multiple CLI JAR files present, instead of renaming them, the command will attempt to move all the JARs to a directory named presto
@imjalpreet good catch! I just tested that by downloading multiple CLI jars then manually renaming the extras to earlier version numbers so I had
in the same directory. The command failed and returned the error Honestly I think that if we need to add a comment to "only [have] one CLI JAR file in the current directory", it might be better for me to put back in the comment
which would help in the case of multiple CLI JAR files. |
SGTM, let's add back in the comment so it's less ambiguous. |
1a80f10
to
8bffe97
Compare
Description
Noticed the command example in installation/cli.rst showed 0.286 instead of 0.290.
As this doc PR, once merged, will be part of the 0.292 release, updated the example command to 0.292.
Motivation and Context
Following the current instructions, the user downloads presto-cli-0.290-executable.jar. The rename command shown in the doc is
mv presto-cli-0.286-executable.jar presto
which does nothing to rename the downloaded presto-cli-0.290-executable.jar.If there's an automated way to pick up the release version of Presto and include it inside a code block, let me know, but if not then manual updates are the best current answer.
Impact
Documentation.
Test Plan
Local doc build. See screenshot in Description for local doc build result.
Contributor checklist
Release Notes