Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ArrowFlightConfig verifyServer true by default #24518

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

BryanCutler
Copy link
Contributor

@BryanCutler BryanCutler commented Feb 7, 2025

Description

The ArrowFlightConfig verifyServer was currently defaulting to NULL, we should explicitly set the default to "true" so that when a certificate is supplied in the config, the client will verify the server. See discussion at #24504 (comment)

Also to make integration testing with the native Arrow connector, this adjusts the testing Arrow connector and catalog name to arrow-flight and arrowflight to match. A test property can be supplied to set worker count to 0 for the testing ArrowFlightQueryRunner to run with native workers.

Motivation and Context

The verifyServer config should be a concrete value to ensure the client connection is secure.

Aligning with native Arrow Flight connector in progress at #24504 will make integration testing easier.

Impact

The ArrowFlightConfig verifyServer and server-ssl-enabled are no longer nullable and verifyServer will default to "true".

Test Plan

Existing tests run with the new connector name and ignore the worker count override to use the default.

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

@BryanCutler BryanCutler requested a review from a team as a code owner February 7, 2025 19:47
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Feb 7, 2025
@prestodb-ci prestodb-ci requested review from a team, ScrapCodes and NivinCS and removed request for a team February 7, 2025 19:47
@BryanCutler BryanCutler changed the title Adjust testing Arrow connector name to arrow-flight Make ArrowFlightConfig verifyServer true by default Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:IBM PR from IBM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants