Make ArrowFlightConfig verifyServer true by default #24518
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The ArrowFlightConfig verifyServer was currently defaulting to NULL, we should explicitly set the default to "true" so that when a certificate is supplied in the config, the client will verify the server. See discussion at #24504 (comment)
Also to make integration testing with the native Arrow connector, this adjusts the testing Arrow connector and catalog name to arrow-flight and arrowflight to match. A test property can be supplied to set worker count to 0 for the testing ArrowFlightQueryRunner to run with native workers.
Motivation and Context
The verifyServer config should be a concrete value to ensure the client connection is secure.
Aligning with native Arrow Flight connector in progress at #24504 will make integration testing easier.
Impact
The ArrowFlightConfig verifyServer and server-ssl-enabled are no longer nullable and verifyServer will default to "true".
Test Plan
Existing tests run with the new connector name and ignore the worker count override to use the default.
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.