Support for complex ORDER BY expressions referencing projection output #6766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kokosing
reviewed
Dec 5, 2016
| public void testOrderByWithProjectionColumnReference() | ||
| { | ||
| assertQueryOrdered("SELECT a*2 AS b FROM (VALUES -1, 0, 2) t(a) ORDER BY b*-1", "VALUES (4), (0), (-2)"); | ||
| assertQueryOrdered("SELECT a*2 AS b FROM (VALUES -1, 0, 2) t(a) ORDER BY b", "VALUES (-2), (0), (4)"); |
There was a problem hiding this comment.
I think you need to add more testing:
SELECT a* -1 AS a FROM (VALUES -1, 0, 2) t(a) ORDER BY a*-1
SELECT a*-1 AS a FROM (VALUES -1, 0, 2) t(a) ORDER BY t.a*-1
SELECT a*-1 FROM (VALUES -1, 0, 2) t(a) ORDER BY a*-1
SELECT a*-1 FROM (VALUES -1, 0, 2) t(a) ORDER BY t.a*-1
There was a problem hiding this comment.
More tests ;)
SELECT a, a* -1 AS a FROM (VALUES -1, 0, 2) t(a) ORDER BY a; -- expected failure
SELECT a, a* -1 AS a FROM (VALUES -1, 0, 2) t(a) ORDER BY t.a;
SELECT a, a* -2 AS b FROM (VALUES -1, 0, 2) t(a) ORDER BY a + b
SELECT a as b, a* -2 AS a FROM (VALUES -1, 0, 2) t(a) ORDER BY a + b;
SELECT a* -2 AS a FROM (VALUES -1, 0, 2) t(a) ORDER BY a + t.a;
SELECT (SELECT 1 as a) FROM (VALUES -1, 0, 2) t(a) ORDER BY a; -- expected failure?
There was a problem hiding this comment.
AFAIK you can write "VALUES -1, 0, 2" for h2 check query (no need for '(', ')')
sopel39
force-pushed
the
feature_support_complex_order_by_expressions
branch
from
aa93b4b to
a9ff893
Compare
kokosing
approved these changes
Dec 5, 2016
| public void testOrderByWithProjectionColumnReference() | ||
| { | ||
| assertQueryOrdered("SELECT a*2 AS b FROM (VALUES -1, 0, 2) t(a) ORDER BY b*-1", "VALUES (4), (0), (-2)"); | ||
| assertQueryOrdered("SELECT a*2 AS b FROM (VALUES -1, 0, 2) t(a) ORDER BY b", "VALUES (-2), (0), (4)"); |
There was a problem hiding this comment.
More tests ;)
SELECT a, a* -1 AS a FROM (VALUES -1, 0, 2) t(a) ORDER BY a; -- expected failure
SELECT a, a* -1 AS a FROM (VALUES -1, 0, 2) t(a) ORDER BY t.a;
SELECT a, a* -2 AS b FROM (VALUES -1, 0, 2) t(a) ORDER BY a + b
SELECT a as b, a* -2 AS a FROM (VALUES -1, 0, 2) t(a) ORDER BY a + b;
SELECT a* -2 AS a FROM (VALUES -1, 0, 2) t(a) ORDER BY a + t.a;
SELECT (SELECT 1 as a) FROM (VALUES -1, 0, 2) t(a) ORDER BY a; -- expected failure?
| public void testOrderByWithProjectionColumnReference() | ||
| { | ||
| assertQueryOrdered("SELECT a*2 AS b FROM (VALUES -1, 0, 2) t(a) ORDER BY b*-1", "VALUES (4), (0), (-2)"); | ||
| assertQueryOrdered("SELECT a*2 AS b FROM (VALUES -1, 0, 2) t(a) ORDER BY b", "VALUES (-2), (0), (4)"); |
There was a problem hiding this comment.
AFAIK you can write "VALUES -1, 0, 2" for h2 check query (no need for '(', ')')
| if (orderByExpression == null) { | ||
| orderByExpression = expression; | ||
| else { | ||
| orderByExpression = ExpressionTreeRewriter.rewriteWith(new OrderByExpressionRewriter(byAlias), expression); |
There was a problem hiding this comment.
IMO instead of using byAlias you should use outputScope
There was a problem hiding this comment.
It may blow up, so please just give it a try
There was a problem hiding this comment.
Scope doesn't provide information about expressions. Extracted a separate method for building assignments map
|
Add to commit message that this commit fixes: #4698 |
sopel39
force-pushed
the
feature_support_complex_order_by_expressions
branch
from
a9ff893 to
6e2cdac
Compare
|
applied comments |
sopel39
force-pushed
the
feature_support_complex_order_by_expressions
branch
2 times, most recently
from
8d94fb8 to
4f62c5e
Compare
|
Instead of referencing the issue in the commit message, describe the actual problem. |
SQL standard specifies that ORDER BY expressions can reference projection outputs. For instance following query works: SELECT x as y FROM (VALUES(1) t(x)) ORDER BY y*-1; This commit adds support for referencing projection outputs from ORDER BY expressions. This fixes prestodb#4698
sopel39
force-pushed
the
feature_support_complex_order_by_expressions
branch
from
4f62c5e to
9e44ae5
Compare
|
rebased & amended commits so it is more descriptive. |
|
I made a couple of minor changes and merged it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes various TPCDS queries to execute unmodified
FYI: @martint