Add config option and session property to restore legacy ORDER BY behavior #6871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cberner
approved these changes
Dec 13, 2016
| @@ -52,6 +52,7 @@ | |||
| private boolean optimizeSingleDistinct = true; | |||
| private boolean pushTableWriteThroughUnion = true; | |||
| private boolean legacyArrayAgg; | |||
| private boolean legacyOrderBy; | |||
There was a problem hiding this comment.
You forgot to add tests for this
|
Failure seems to be unrelated. |
…avior We recently made a change to the column resolution rules for ORDER BY to make them compliant with ANSI SQL. In order to ease the transition from the old semantics, we now add a config option and session property that controls the behavior. The session property is "legacy_order_by". The config option is "deprecated.legacy-order-by".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently made a change to the column resolution rules for ORDER BY to
make them compliant with ANSI SQL. In order to ease the transition from
the old semantics, we now add a config option and session property that
controls the behavior.
The session property is "legacy_order_by". The config option is
"deprecated.legacy-order-by".
This will be removed in a not-too-distant version.
Fixes #6867