Fix parallel builds for agbcc, remove configure artifacts from gcc_arm, attempt to fix travis build, add github workflows CI file #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
they get generated just fine by configure
…s of agbcc, libc and libgcc to match paths
…l.sh to work with the same environment the makefile uses
Missingmew
changed the title
this should be expanded if dka becomes optional at some point
…and error output for libc and libgcc Makefiles when neither arm-none-eabi-as nor devkitARM are found
|
Looks interesting! Mind if this is rebased so you fix your merge conflicts first? |
|
Conflicts should be gone now, feel free to do as you like. |
This was referenced Jun 24, 2022
Closed
|
@Missingmew all the relevant points and more from this PR have been separated into individual PRs each. Please close this PR. |
|
Closing as requested by @coltongit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title.
Parallel builds for agbcc are fixed by adding
genrtl.hto the rule that builds the generator executable objects (since all of them depend on it), which in turn fixes parallel builds for the entire thing.Current master has artifacts from
configurein gcc_arm which dont need to be kept, sinceconfigureas called frombuild.shgenerates those just fine. Additionally this switches from selectively deleting two artifacts to justmake distclean.Travis fails because of not finding
zlib-dev. According to ubuntu package repos, the package should be calledzlib1g-devso this should theoretically fix travis (changes taken from #31 to get travis to work).Additionally, this PR now includes a github workflows CI config file to potentially drop travis in the future due to their changes in usage for free users.
Changes from #37 have been incorporated, the github workflows file has been modified to build both with and without devkitARM.