Simplify RAM reset adaptation for modern #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
ghoulslash
pushed a commit
to ghoulslash/pokeemerald
that referenced
this pull request
Mar 28, 2021
Remove Techno Blast and Judgment from battle scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When compiling with newer versions of gcc, AgbMain preserves more registers than when compiled with agbcc. This results in the vanilla RegisterRamReset call crashing, due to the return address on the stack being overwritten with 0. The current fix injects a manual loop into AgbMain to clear IWRAM. The proposed solution instead moves the RegisterRamReset to crt0 when compiling with modern gcc. It's more efficient and less of an eyesore this way.
Discord contact info
PikalaxALT#5823