[LEAK INFORMED] Documented the unk19 item field #1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemondrop81
pushed a commit
to lemondrop81/pokeemerald
that referenced
this pull request
Dec 18, 2021
Fix Arctozolt, Heliolisk, and Chespin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This field is called "convenience button" in the original source code of Pokémon Emerald.
My personal guess is that the field was meant to signal that the Player should be allowed to register the items that have this field set to 1/
TRUE.As all the items from the no. 360 (FRLG's Bicycle) to the no. 366 (Teachy TV) have the flag set to "1", I suspect that the items inserted afterward, which a Player has no reason to register for usage with the Select button with the exception of the Powder Jar, simply have it set to 1/
TRUEby mistake, either because they were automatically generated or because whoever was in charge of writing the data of those items simply followed the lead of the items that come before.Fun story:
In the original code, there's actually 2 fields that share the same name.
There's this field in the Items' data that Pret currently calls
unk19, and then there's the field that Pret calls "registeredItem" inside of theSaveBlock1struct.Both of them have the exact same name in the original source code.
That coincidence is the sole reason why I was able to come up with this theory of mine.
Discord contact info
Lunos#4026