Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix names and constant usage for union room classes #1749

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Fix names and constant usage for union room classes #1749

merged 1 commit into from
Sep 7, 2022

Conversation

GriffinRichards
Copy link
Member

  • Clarify that gLinkPlayerFacilityClasses is only for the Union Room
  • Use the array size constants in GetUnionRoomTrainerPic/GetUnionRoomTrainerClass
  • Fix incorrect constant usage for sUnionRoomObjGfxIds

Blackforest92 pushed a commit to Blackforest92/pokeemerald that referenced this pull request Aug 24, 2022
@BuffelSaft
Merge pull request pret#1749 from ghoulslash/wandering_spirit
fbce8b2 
Wandering Spirit
@GriffinRichards GriffinRichards merged commit 74b563f into pret:master Sep 7, 2022
@GriffinRichards GriffinRichards deleted the ur-classes branch September 7, 2022 01:35
github-actions bot pushed a commit that referenced this pull request Sep 7, 2022
@GriffinRichards
Merge pull request #1749 from GriffinRichards/ur-classes
b181198
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@GriffinRichards