Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added parenthesis to GET_SHINY_VALUE #1776

Merged
merged 1 commit into from
Sep 11, 2022

Conversation

AsparagusEduardo
Copy link
Contributor

Description

Trying to use GET_SHINY_VALUE in other contexts causes a warning:

warning: suggest parentheses around comparison in operand of ^

eg: while (GET_SHINY_VALUE(value, personality) >= SHINY_ODDS && totalRerolls > 0)

Discord contact info

AsparagusEduardo#6051

@GriffinRichards GriffinRichards merged commit 91cba0e into pret:master Sep 11, 2022
@AsparagusEduardo AsparagusEduardo deleted the pret/pr/ShinyValue branch August 13, 2023 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants