Identify more bit flags #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rangi42
force-pushed
the
more-bit-flags
branch
from
100cfb9 to
25bc910
Compare
Rangi42
commented
Sep 24, 2024
| @@ -27,7 +27,7 @@ VictoryRoad2FCheckBoulderEventScript: | |||
| call VictoryRoad2FReplaceTileBlockScript | |||
| pop af | |||
| .not_on_switch | |||
| bit 7, a | |||
| CheckEventReuseA EVENT_VICTORY_ROAD_2_BOULDER_ON_SWITCH2 | |||
dannye
reviewed
Sep 24, 2024
|
wCurrentMapScriptFlags 5 and 6 are both "new map was just loaded" flags used to ensure map scripts only run a function once when the map is loaded. I think the idea was that they could be re-set individually to re-trigger specific map load functions on a map, but I don't think that's ever done in a place where them being separate matters. |
|
Thanks, Vortyne. Yeah, I had noticed some of that after giving them |
PokefanMarcel
pushed a commit
to PokefanMarcel/yumepokered
that referenced
this pull request
Oct 18, 2024
* Identify more bit flags * Space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this PR, there are two types of unidentified bit flags remaining: hardware register bits (for which I'm considering how much to edit/refactor hardware_constants.asm based on hardware.inc), and
wCurrentMapScriptFlagsbits 5, 6, and 7 (which need more case-by-case investigation).