Apply "internal reference" as buyer reference in standard profile, an…

…d only override in XRechnung profile if custom field is defined (Z#23104892) (#7) * Apply "internal reference" as buyer reference in standard profile, and only override in XRechnung profile if custom field is defined * Fix failing tests
pretix · Feb 6, 2025 · a0d16f5 · a0d16f5
1 parent 49f72cb
commit a0d16f5
Show file tree

Hide file tree

Showing 8 changed files with 10 additions and 1 deletion.
diff --git a/pretix_zugferd/invoice.py b/pretix_zugferd/invoice.py
@@ -268,6 +268,7 @@ def _zugferd_generate_document(self, invoice):
         doc.header.notes.add(note)
 
         if invoice.internal_reference:
+            doc.trade.agreement.buyer_reference = invoice.internal_reference
             note = IncludedNote()
             note.content.add(
                 pgettext("invoice", "Customer reference: {reference}").format(
@@ -504,5 +505,6 @@ class Modern1ZugferdXRechnungInvoiceRenderer(ZugferdMixin, Modern1Renderer):
 
     def _zugferd_generate_document(self, invoice):
         doc = super()._zugferd_generate_document(invoice)
-        doc.trade.agreement.buyer_reference = invoice.custom_field or "unknown"
+        if self.event.settings.invoice_address_custom_field:
+            doc.trade.agreement.buyer_reference = invoice.custom_field or "unknown"
         return doc
diff --git a/tests/results/cancellation.xml b/tests/results/cancellation.xml
@@ -73,6 +73,7 @@ Attendee: Peter</ram:Description>
             </ram:SpecifiedLineTradeSettlement>
         </ram:IncludedSupplyChainTradeLineItem>
         <ram:ApplicableHeaderTradeAgreement>
+            <ram:BuyerReference>PO-12345</ram:BuyerReference>
             <ram:SellerTradeParty>
                 <ram:Name>Musterfirma</ram:Name>
                 <ram:PostalTradeAddress>

diff --git a/tests/results/default.xml b/tests/results/default.xml
@@ -73,6 +73,7 @@ Attendee: Peter</ram:Description>
             </ram:SpecifiedLineTradeSettlement>
         </ram:IncludedSupplyChainTradeLineItem>
         <ram:ApplicableHeaderTradeAgreement>
+            <ram:BuyerReference>PO-12345</ram:BuyerReference>
             <ram:SellerTradeParty>
                 <ram:Name>Musterfirma</ram:Name>
                 <ram:PostalTradeAddress>

diff --git a/tests/results/delivery_date_off.xml b/tests/results/delivery_date_off.xml
@@ -73,6 +73,7 @@ Attendee: Peter</ram:Description>
             </ram:SpecifiedLineTradeSettlement>
         </ram:IncludedSupplyChainTradeLineItem>
         <ram:ApplicableHeaderTradeAgreement>
+            <ram:BuyerReference>PO-12345</ram:BuyerReference>
             <ram:SellerTradeParty>
                 <ram:Name>Musterfirma</ram:Name>
                 <ram:PostalTradeAddress>

diff --git a/tests/results/paid.xml b/tests/results/paid.xml
@@ -73,6 +73,7 @@ Attendee: Peter</ram:Description>
             </ram:SpecifiedLineTradeSettlement>
         </ram:IncludedSupplyChainTradeLineItem>
         <ram:ApplicableHeaderTradeAgreement>
+            <ram:BuyerReference>PO-12345</ram:BuyerReference>
             <ram:SellerTradeParty>
                 <ram:Name>Musterfirma</ram:Name>
                 <ram:PostalTradeAddress>

diff --git a/tests/results/tax_code_exempt.xml b/tests/results/tax_code_exempt.xml
@@ -73,6 +73,7 @@ Attendee: Peter</ram:Description>
             </ram:SpecifiedLineTradeSettlement>
         </ram:IncludedSupplyChainTradeLineItem>
         <ram:ApplicableHeaderTradeAgreement>
+            <ram:BuyerReference>PO-12345</ram:BuyerReference>
             <ram:SellerTradeParty>
                 <ram:Name>Musterfirma</ram:Name>
                 <ram:PostalTradeAddress>

diff --git a/tests/results/tax_code_guess_AU.xml b/tests/results/tax_code_guess_AU.xml
@@ -73,6 +73,7 @@ Attendee: Peter</ram:Description>
             </ram:SpecifiedLineTradeSettlement>
         </ram:IncludedSupplyChainTradeLineItem>
         <ram:ApplicableHeaderTradeAgreement>
+            <ram:BuyerReference>PO-12345</ram:BuyerReference>
             <ram:SellerTradeParty>
                 <ram:Name>Musterfirma</ram:Name>
                 <ram:PostalTradeAddress>

diff --git a/tests/results/tax_code_reverse_charge.xml b/tests/results/tax_code_reverse_charge.xml
@@ -73,6 +73,7 @@ Attendee: Peter</ram:Description>
             </ram:SpecifiedLineTradeSettlement>
         </ram:IncludedSupplyChainTradeLineItem>
         <ram:ApplicableHeaderTradeAgreement>
+            <ram:BuyerReference>PO-12345</ram:BuyerReference>
             <ram:SellerTradeParty>
                 <ram:Name>Musterfirma</ram:Name>
                 <ram:PostalTradeAddress>