Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pypdf lib and fix generation issues #6

Merged
merged 1 commit into from
May 2, 2023

Conversation

cmcproject
Copy link
Contributor

@cmcproject cmcproject commented May 1, 2023

  • Switch from PyPDF2 -> pypdf
    • The PyPDF2 project is going back to its roots. PyPDF2==3.0.X will be the last version of PyPDF2. Development will continue with pypdf==3.1.0.
  • Fix output intents generation
  • Fix NameObject generation error; e
    • NameObject error is raised every time you generate an invoice; therefore, replace NameObject with create_string_object for the metadata size field
  • Add logging to pdf generation

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Patch coverage: 92.30% and project coverage change: +0.01 🎉

Comparison is base (630dc41) 90.54% compared to head (0450a46) 90.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
+ Coverage   90.54%   90.55%   +0.01%     
==========================================
  Files          17       17              
  Lines        1396     1398       +2     
==========================================
+ Hits         1264     1266       +2     
  Misses        132      132              
Impacted Files Coverage Δ
drafthorse/pdf.py 92.46% <91.66%> (+0.10%) ⬆️
drafthorse/__init__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@raphaelm raphaelm merged commit 6375c60 into pretix:master May 2, 2023
cmcproject added a commit to cmcproject/python-drafthorse that referenced this pull request May 2, 2023
Upgrade pypdf lib and fix generation issues (pretix#6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants