Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clarification notice about Flow/React support to the readme #95

Closed
kripod opened this issue Jun 23, 2018 · 2 comments
Closed

Add clarification notice about Flow/React support to the readme #95

kripod opened this issue Jun 23, 2018 · 2 comments

Comments

@kripod
Copy link
Contributor

kripod commented Jun 23, 2018 •
edited
Loading

In the readme’s “Recommended Configuration” section, there are no instructions about the need to add e.g. ”extends”: [”prettier/react”] to support its corresponding ESLint plugin.

I think there should be at least a clarification notice about this for disabling rules of special ESLint plugins (e.g. eslint-plugin-react).

Example: https://github.com/kripod/gatsby-starter-modern/blob/cabc047185ffdfe27c29d31071999d80fe39b474/.eslintrc.json#L3
@not-an-aardvark
Copy link
Member

Sounds reasonable to me, would you be interested in creating a PR?

kripod added a commit to kripod/eslint-plugin-prettier that referenced this issue Jun 25, 2018
@kripod
Add clarification notice about Flow/React support to the readme
2ff6fa3 
Resolves prettier#95
@kripod kripod mentioned this issue Jun 25, 2018
Merged
@kripod
Copy link
Contributor Author

kripod commented Jun 25, 2018

Sure, it’s done.

not-an-aardvark pushed a commit that referenced this issue Jul 2, 2018
@kripod @not-an-aardvark
Docs: Add clarification about Flow/React support to readme (#96)
977aa77 
Resolves #95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@not-an-aardvark @kripod