Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable GitHub actions #1272

Merged
merged 2 commits into from
Jan 2, 2020
Merged

feat: enable GitHub actions #1272

merged 2 commits into from
Jan 2, 2020

Conversation

czosel
Copy link
Collaborator

@czosel czosel commented Jan 2, 2020 •
edited
Loading

  • Windows build
  • Coverage upload
  • Remove appveyor and travis

@czosel czosel force-pushed the github-actions branch 2 times, most recently from d435b01 to d8ddc02 Compare January 2, 2020 17:11
@czosel
Copy link
Collaborator Author

czosel commented Jan 2, 2020

The windows build is failing due to LF/CRLF issues - interesting that appveyor didn't catch this...

@czosel
Copy link
Collaborator Author

czosel commented Jan 2, 2020

Uploading to codecov currently doesn't seem to work from forks:
codecov/codecov-action#29
codecov/codecov-node#118

Maybe we should skip it for now?

@loilo
Copy link
Collaborator

loilo commented Jan 2, 2020

Sorry, I'm so not qualified to review this. 🙈

@czosel
Copy link
Collaborator Author

czosel commented Jan 2, 2020

😅 How come?

@loilo
Copy link
Collaborator

loilo commented Jan 2, 2020

I have not even remotely had any contact with GitHub actions. 😅

@czosel
Copy link
Collaborator Author

czosel commented Jan 2, 2020

Me neither until a few hours ago 😅

@czosel
Copy link
Collaborator Author

czosel commented Jan 2, 2020

I'd love to see if the build over at #1269 would work with GitHub actions. I guess I'm gonna go ahead and merge this - we can always revert it if someone has an issue with it 🙈

cc @evilebottnawi

@czosel
Copy link
Collaborator Author

czosel commented Jan 2, 2020

The build of #1269 really works with GitHub actions. Let's go ahead and replace the travis caching issue with a new, hopefully small set of future issues with GitHub actions 😉

@czosel czosel merged commit b2a0766 into master Jan 2, 2020
@czosel czosel deleted the github-actions branch January 2, 2020 20:43
@alexander-akait
Copy link
Member

All good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait Awaiting requested review from alexander-akait

@loilo loilo Awaiting requested review from loilo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@czosel @loilo @alexander-akait