Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependencies #338

Merged
merged 2 commits into from
May 22, 2020

Conversation

hamzahamidi
Copy link
Collaborator

@hamzahamidi hamzahamidi commented May 22, 2020

dependencies

  • "@typescript-eslint/parser": "^3.0.0"
  • "eslint": "^6.8.0"
  • "typescript": "^3.9.3"
  • "vue-eslint-parser": "~7.1.0"

devDependencies

  • "ajv": "^6.12.2"
  • "babel-jest": "^25.0.0"
  • "jest": "^25.0.0"
  • "jest-cli": "^25.0.0"
  • "prettier-eslint-cli": "^5.0.0"

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2020

Codecov Report

Merging #338 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #338   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          208       208           
  Branches        42        42           
=========================================
  Hits           208       208           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb19c6e...2b929c2. Read the comment docs.

@hamzahamidi hamzahamidi changed the title chore: update dependencies chore(dep): update dependencies May 22, 2020
@hamzahamidi hamzahamidi changed the title chore(dep): update dependencies chore(deps): update dependencies May 22, 2020
@hamzahamidi hamzahamidi merged commit 29e9d1e into prettier:master May 22, 2020
@hamzahamidi hamzahamidi deleted the build/update-dependencies branch May 22, 2020 16:32
@chrisbobbe
Copy link
Contributor

chrisbobbe commented May 22, 2020

Hi @hamzahamidi! I saw at #275 (comment) that you're taking over maintainership of this repo. Thanks a lot!

Thanks for these updates here. This one, in particular, looks like it's necessary for guaranteed support of ESLint 6:

-   "@typescript-eslint/parser": "^1.10.2",
+   "@typescript-eslint/parser": "^3.0.0",

because @typescript-eslint/parser at 1.10.2 has ESLint 5 as a peer dependency (link), and not ESLint 6.

@typescript-eslint/parser at 3.0.0 has moved on to ESLint 7, but, thankfully, it still has ESLint 6 as a peer dependency (link). (It also has ESLint 5.)

It looks like there were several automatically generated PRs from the in-between-maintainers times, that look like they would have granted ESLint 6 support (with ESLint 5 compatibility) before the 10.0.0 release of this package. This would have been done by using @typescript-eslint/parser at 2.x.x, which has ESLint 6 and 5 compatibility (2.34.0, 2.0.0). Those are #273, #274, #276, #282, #286, #290, #292, #294, #297, #299, #302, #303, #304, #308, #311, #314, #317, #320, #321, #323, #329, #330, and #333. (These auto-generated PRs easily fall through the cracks, especially when they also auto-close!) Anyway, no harm done, and I'm looking forward to the release of the commit in this PR.

Thanks again!

@zimme
Copy link
Member

zimme commented May 24, 2020

🎉 This PR is included in version 10.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@zimme zimme added the released label May 24, 2020
@chrisbobbe
Copy link
Contributor

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants