ftdetect collides with default filetype settings (specifically typescriptreact or tsx)

[gadkadosh]

My experience is specifically with typescriptreact, where vim-prettier changes the default typescriptreact to typescript. This breaks my completion plugin, for example, which depends on typescriptreact for jsx apparently.

The question is why should vim-prettier touch those filetype detections at all? I feel like if they get correctly set by default vim or nvim, vim-prettier shouldn't interfere. Maybe it's from a time when those were not set correctly?

[yzia2000]

It seems to format for me regardless of the filetype. Let me make a pr to adjust this

[gadkadosh]

Just for my curiosity: why does vim-prettier have to declare filetypes at all? Why not leave that to vim runtime or to specialised plugins? Is it a best practice because it has ftdetects?

[yzia2000]

This is just a guess but I believe they felt that certain filetypes might not interface well with prettier, or probably an early bug fix. I myself would rather stick to vim runtime.