Shore/master rebasing #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrap the path used for `stdin-filepath` in quotes. references #108
Per Prettier's [Blog Post](https://prettier.io/blog/2018/11/07/1.15.0.html) there is an option for prettiers sensitivity to html whitespace. See blog post for more details. This adds that option to vim-prettier and sets the default to the prettier default.
Fix markdown mangling issue
Add option for html whitespace sensitivity
Handle file paths with whitespace
Make markdown check more resilient
Ignore generated help tags file
Added some file extensions
improve Requirement's message clearness
This is one approach for handling default prettier arguments. It is a little verbose, but I think ejecting the flags that don't have to be set by the editor (in favor of .prettierrc files) is a win.
- This is the first commit on refactoring methods outs on self contained components, this will help on unit testing and maintainability
- Refactoring parser out into its own module in order to make it easier to test
- Refactoring the executable resolver into its own module for making it easier to test
- Movingthe shiftwidth compat helper to a shim module responsible for dealing with backwards compatiblity
- prefer-file setting for config-precedence is what allow us to leverage from user defined configuration files like .prettierrc
- adding facebook presets as a configurable option to overwrite prettier defaults
- Making sure we do not try to format a file again until execution is finally finished
If user have custom file type plugin that set "parser" option, calling ":Prettier" will return error "Prettier: failed to parse buffer". This was caused by running prettier with CLI option "--parser X" with "--config-precedence prefer_file" will cause prettier to ignore the "parser" option. Fix #178
- the new version of prettier ruby has support for older node versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please make sure the following is done...
master.vim8andneovim./doc/prettier.txtPlease use the simple form below as a guideline for describing your pull request.
Thanks for contributing to vim-prettier
Summary
[...]
Test Plan
[...]