Adding support for require-pragma and depracting previous naive implemenation #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Our previous undo implementation tried to be naive on implementing require-pragma, and created some undo bugs due to it. This diff enables us to use the prettier upstream support for require-pragma - On subsequent PR's we will completetly phase out the previous undo implementation in favour to this one in order to fix bug #184
requirePragma - This commit ensures that we use `prettier` default way to identify pragmas for the auto save and remove our previous naive implementation
mitermayer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff adds support for
require-pragmaoptionRemoves naive implementation of
require-pragmain favour ofprettiercli implementation. There should be no change of behaviour besides some performances improvements as we no longer scan through the file in search of pragma tagsThis diff also enables user to autoformat based on
@prettiertag as well as@formatas opposed to just@format