Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CG-05 #123 #125

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

CG-05 #123 #125

wants to merge 4 commits into from

Conversation

Gonhub9
Copy link
Collaborator

@Gonhub9 Gonhub9 commented Feb 25, 2025

๐Ÿ“Part

  • BE

  • FE

  • Infra


โœ”๏ธPR Type

  • ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ ์ถ”๊ฐ€

  • ๋ฒ„๊ทธ ์ˆ˜์ •

  • ์ฃผ์š” ์ฝ”๋“œ ๋ฆฌํŽ™ํ† ๋ง (์„ฑ๋Šฅ ์ตœ์ ํ™” ๋“ฑ)

  • ๊ฐ„๋‹จ ์ฝ”๋“œ ๋ฆฌํŽ™ํ† ๋ง (์ฃผ์„, ์ฝ”๋“œ ์ปจ๋ฒค์…˜, ์˜คํƒ€ ์ˆ˜์ • ๋“ฑ)

  • ๊ธฐํƒ€ (๊ธฐํƒ€ ์‚ฌํ•ญ ๊ธฐ์ž…)


โœ”๏ธPR Checklist

  • ์ปค๋ฐ‹ ๋ฉ”์„ธ์ง€๋ฅผ ์ปจ๋ฒค์…˜์— ๋งž๊ฒŒ ์ž˜ ์ ์šฉ ํ•˜์˜€๋‚˜์š”?

  • ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ž‘์„ฑ / ๋‹จ์œ„ ํ…Œ์ŠคํŠธ or ํ†ตํ•ฉ ํ…Œ์ŠคํŠธ ์ง„ํ–‰ ํ•˜์…จ๋‚˜์š”?


๐Ÿ”Ž ์ž‘์—… ๋‚ด์šฉ

  • CategoryService ์ถ”๊ฐ€ ๋กœ์ง์— ํŠธ๋žœ์žญ์…˜ ์ถ”๊ฐ€ํ•ด์„œ ์ผ๊ด€๋œ ํŠธ๋žœ์žญ์…˜ ๊ด€๋ฆฌ

  • CategoryController categorieList -> categoryList๋กœ ์ผ๊ด€๋˜๊ฒŒ ์ˆ˜์ •, ResponseStatus ์‚ญ์ œ

  • CategoryConverter ๋ฉ”์„œ๋“œ ์ด๋ฆ„ ๋ณ€๊ฒฝ์œผ๋กœ ๊ฐ€๋…์„ฑ์„ ๋†’์ž„


๐Ÿ“ˆ์ด๋ฏธ์ง€ ์ฒจ๋ถ€

resolves #123
close #123

@Gonhub9 Gonhub9 linked an issue Feb 25, 2025 that may be closed by this pull request
CG-05 #123
Open
@Gonhub9 Gonhub9 self-assigned this Feb 25, 2025
@Gonhub9 Gonhub9 added the refactoring ๋ฆฌํŒฉํ† ๋ง label Feb 25, 2025
kdo1999
kdo1999 approved these changes Feb 26, 2025
View reviewed changes
Copy link
Collaborator

@kdo1999 kdo1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ˆ˜์ •ํ•ด์•ผ ๋  ๋ถ€๋ถ„ ์—†์Šต๋‹ˆ๋‹ค.
์ˆ˜๊ณ ํ•˜์…จ์Šต๋‹ˆ๋‹ค!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdo1999 kdo1999 kdo1999 approved these changes

@sungyeong98 sungyeong98 sungyeong98 approved these changes

@Janghyeonsuk Janghyeonsuk Awaiting requested review from Janghyeonsuk

@richard3251 richard3251 Awaiting requested review from richard3251

@zelly-log zelly-log Awaiting requested review from zelly-log

Assignees

@Gonhub9 Gonhub9

Labels
refactoring ๋ฆฌํŒฉํ† ๋ง
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CG-05
3 participants
@Gonhub9 @kdo1999 @sungyeong98