Fixed #10919 - Some menu components not supporting ctrl click to open…

… new duplicate screen
primefaces · Dec 7, 2021 · 1af0f51 · 1af0f51
1 parent 022e574
commit 1af0f51
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/src/app/components/breadcrumb/breadcrumb.ts b/src/app/components/breadcrumb/breadcrumb.ts
@@ -81,7 +81,7 @@ export class Breadcrumb {
             return;
         }
 
-        if (!item.url) {
+        if (!item.url && !item.routerLink) {
             event.preventDefault();
         }
 

diff --git a/src/app/components/megamenu/megamenu.ts b/src/app/components/megamenu/megamenu.ts
@@ -169,13 +169,13 @@ export class MegaMenu implements AfterContentInit {
         }
     }
 
-    itemClick(event, item: MenuItem | MegaMenuItem) {
+    itemClick(event: MouseEvent, item: MenuItem | MegaMenuItem) {
         if (item.disabled) {
             event.preventDefault();
             return;
         }
 
-        if (!item.url) {
+        if (!item.url && !item.routerLink) {
             event.preventDefault();
         }
 

diff --git a/src/app/components/menu/menu.ts b/src/app/components/menu/menu.ts
@@ -270,13 +270,13 @@ export class Menu implements OnDestroy {
         this.hide();
     }
 
-    itemClick(event, item: MenuItem) {
+    itemClick(event: MouseEvent, item: MenuItem) {
         if (item.disabled) {
             event.preventDefault();
             return;
         }
 
-        if (!item.url) {
+        if (!item.url && !item.routerLink) {
             event.preventDefault();
         }
 

diff --git a/src/app/components/panelmenu/panelmenu.ts b/src/app/components/panelmenu/panelmenu.ts
@@ -19,7 +19,7 @@ export class BasePanelMenuItem {
         item.expanded = !item.expanded;
         this.ref.detectChanges();
 
-        if (!item.url) {
+        if (!item.url && !item.routerLink) {
             event.preventDefault();
         }
 

diff --git a/src/app/components/slidemenu/slidemenu.ts b/src/app/components/slidemenu/slidemenu.ts
@@ -79,7 +79,7 @@ export class SlideMenuSub implements OnDestroy {
             return;
         }
 
-        if (!item.url) {
+        if (!item.url && !item.routerLink) {
             event.preventDefault();
         }
-Original file line number
+Diff line change
@@ Expand Up / @@ -81,7 +81,7 @@ export class Breadcrumb { @@
                 return;
             }
-            if (!item.url) {
+            if (!item.url && !item.routerLink) {
                 event.preventDefault();
             }
@@ Expand Down @@