Fixed #12382 - MultiSelect: onPanelHide triggers twice

primefaces · Jan 2, 2023 · 95cd25d · 95cd25d
1 parent 7b11857
commit 95cd25d
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/src/app/components/overlay/overlay.ts b/src/app/components/overlay/overlay.ts
@@ -344,11 +344,14 @@ export class Overlay implements AfterContentInit, OnDestroy {
     }
 
     hide(overlay?: HTMLElement, isFocus: boolean = false) {
-        this.onVisibleChange(false);
-        this.handleEvents('onHide', { overlay: overlay || this.overlayEl, target: this.targetEl, mode: this.overlayMode });
-
-        isFocus && DomHandler.focus(this.targetEl);
-        this.modal && DomHandler.removeClass(this.document?.body, 'p-overflow-hidden');
+        if (!this.visible) {
+            return;
+        } else {
+            this.onVisibleChange(false);
+            this.handleEvents('onHide', { overlay: overlay || this.overlayEl, target: this.targetEl, mode: this.overlayMode });
+            isFocus && DomHandler.focus(this.targetEl);
+            this.modal && DomHandler.removeClass(this.document?.body, 'p-overflow-hidden');
+        }
     }
 
     alignOverlay() {
@@ -360,7 +363,7 @@ export class Overlay implements AfterContentInit, OnDestroy {
         this.visibleChange.emit(visible);
     }
 
-    onOverlayClick() {
+    onOverlayClick(event) {
         this.isOverlayClicked = true;
     }