Merge pull request #12431 from primefaces/revert-12402-focus-trap-fix

Revert "#12349 focus trap breaking on elements whose ancestors are hidden"
primefaces · Dec 28, 2022 · dea5a89 · dea5a89
2 parents 69b9e6a + 07480b4
commit dea5a89
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/app/components/dom/domhandler.ts b/src/app/components/dom/domhandler.ts
@@ -615,7 +615,7 @@ export class DomHandler {
 
         let visibleFocusableElements = [];
         for (let focusableElement of focusableElements) {
-            if (!!(focusableElement.offsetWidth || focusableElement.offsetHeight || focusableElement.getClientRects().length)) visibleFocusableElements.push(focusableElement);
+            if (getComputedStyle(focusableElement).display != 'none' && getComputedStyle(focusableElement).visibility != 'hidden') visibleFocusableElements.push(focusableElement);
         }
         return visibleFocusableElements;
     }