Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password | Add maxlength #12531

Closed
mkumar92 opened this issue Jan 19, 2023 · 1 comment · Fixed by #12575
Closed

Password | Add maxlength #12531

mkumar92 opened this issue Jan 19, 2023 · 1 comment · Fixed by #12575
Assignees
@cetincakiroglu
Labels
Type: New Feature Issue contains a new feature or new component request
Milestone
15.2.0

Comments

@mkumar92
Copy link

mkumar92 commented Jan 19, 2023 •
edited
Loading

Describe the bug

<p-password [maxlength]="20" (keydown.space)="$event.preventDefault();"
[toggleMask]="true" [inputStyleClass]="'form-control'" [styleClass]="'w-100 verifyPassword__input'">

Environment

dev

Reproducer

No response

Angular version

14.0.7

PrimeNG version

14.2.2

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

v16.15.0

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

need to stop entering more than max limit.
@mkumar92 mkumar92 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 19, 2023
@cetincakiroglu cetincakiroglu changed the title maxlength not working on password Passowrd Jan 28, 2023
@cetincakiroglu cetincakiroglu changed the title Passowrd Password | Add maxlength Jan 28, 2023
@cetincakiroglu cetincakiroglu added Type: New Feature Issue contains a new feature or new component request and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 28, 2023
@cetincakiroglu cetincakiroglu self-assigned this Jan 28, 2023
@cetincakiroglu
Copy link
Contributor

Hi,

maxlength is not an input property of p-password. This feature does not exist, so I've changed the topic and labelled as new feature.

cetincakiroglu added a commit that referenced this issue Jan 28, 2023
@cetincakiroglu
Fixed #12531 - Password | Add maxlength
e3991e8
@cetincakiroglu cetincakiroglu mentioned this issue Jan 28, 2023
Merged
cetincakiroglu added a commit that referenced this issue Jan 28, 2023
@cetincakiroglu
Merge pull request #12575 from primefaces/issue-12531
57aec85 
Fixed #12531 - Password | Add maxlength
@cetincakiroglu cetincakiroglu added this to the 15.2.0 milestone Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cetincakiroglu cetincakiroglu

Labels
Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Milestone
15.2.0
Development

Successfully merging a pull request may close this issue.

Fixed #12531 - Password | Add maxlength primefaces/primeng
2 participants
@mkumar92 @cetincakiroglu