Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultiSelect Empty Filter Message / Template is not working when you have options #14057

Closed
avim101 opened this issue Nov 8, 2023 · 0 comments · Fixed by #14096
Closed

MultiSelect Empty Filter Message / Template is not working when you have options #14057

avim101 opened this issue Nov 8, 2023 · 0 comments · Fixed by #14096
Labels
LTS-PORTABLE Issue's fix will be ported to supported LTS versions Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
16.9.0

Comments

@avim101
Copy link

avim101 commented Nov 8, 2023

Describe the bug

When filtering the multi-select component and there are no results, the empty logic is not functioning as intended.

The issue lies in the following logic:

ngIf="hasFilter() && isEmpty()"

ngIf="!hasFilter() && isEmpty()"

hasFilter works as expected, but isEmpty returns the array of options regardless of the filter.

Environment

Angular application using Primeng

Reproducer

https://stackblitz.com/edit/github-vr1phw?file=src%2Fapp%2Fapp.component.html

Angular version

16.2.0

PrimeNG version

16.7.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

16.19.1

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@avim101 avim101 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 8, 2023
ashikjs added a commit to ashikjs/primeng that referenced this issue Nov 13, 2023
@ashikjs
fix: primefaces#14057 || MultiSelect Empty Filter Message / Template …
cb08919 
…is not working when you have options
@ashikjs ashikjs mentioned this issue Nov 13, 2023
Merged
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 22, 2023
@cetincakiroglu cetincakiroglu added this to the 16.9.0 milestone Nov 22, 2023
cetincakiroglu added a commit that referenced this issue Nov 22, 2023
@cetincakiroglu
Merge pull request #14096 from ashikjs/issues-14057/multiSelect-filte…
ae2cc95 
…r-empty-message-not-show

fix: #14057 || MultiSelect Empty Filter Message / Template is not working when you have options
mati4455 pushed a commit to mati4455/primeng that referenced this issue Dec 20, 2023
fix isEmpty checking for dropdown component when using filters (simil…
1df98b1 
…ar to primefaces#14057)
@cetincakiroglu cetincakiroglu added the LTS-PORTABLE Issue's fix will be ported to supported LTS versions label Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
LTS-PORTABLE Issue's fix will be ported to supported LTS versions Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
16.9.0
2 participants
@avim101 @cetincakiroglu