Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon: Mistake in example documentation code #16277

Closed
shaman-apprentice opened this issue Aug 23, 2024 · 0 comments · Fixed by #16278
Closed

Icon: Mistake in example documentation code #16277

shaman-apprentice opened this issue Aug 23, 2024 · 0 comments · Fixed by #16278
Labels
Component: Documentation Issue or pull request is related to Documentation
Milestone

Comments

@shaman-apprentice
Copy link
Contributor

Describe the bug

The following example code in https://primeng.org/icons#color is not working as expected: <i class="pi pi-search" style="color: 'var(--primary-color)'"></i>

I guess the quotes around the css var are a copy paste mistake. I will quickly create a PR to fix / update the documentation.

Environment

Not relevant

Reproducer

No response

Angular version

17.x.x

PrimeNG version

17.8.9

Build / Runtime

Angular CLI App

Language

ALL

Node version (for AoT issues node --version)

20.x.x

Browser(s)

No response

Steps to reproduce the behavior

  1. Copy paste exmaple from color section

Expected behavior

Third icon has the primary color, which it will not have.

@shaman-apprentice shaman-apprentice added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 23, 2024
@mehmetcetin01140 mehmetcetin01140 added the Component: Documentation Issue or pull request is related to Documentation label Sep 10, 2024
@mehmetcetin01140 mehmetcetin01140 added this to the 17.18.10 milestone Sep 10, 2024
@mehmetcetin01140 mehmetcetin01140 removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 10, 2024
mehmetcetin01140 added a commit that referenced this issue Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation Issue or pull request is related to Documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants