Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p-tabview closing active first tab opens not the next tab #16313

Closed
DbkMG opened this issue Aug 30, 2024 · 0 comments · Fixed by #16531
Closed

p-tabview closing active first tab opens not the next tab #16313

DbkMG opened this issue Aug 30, 2024 · 0 comments · Fixed by #16531
Assignees
@mehmetcetin01140
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.18.13

Comments

@DbkMG
Copy link

DbkMG commented Aug 30, 2024 •
edited
Loading

Describe the bug

the current implementation in closable tabview opens the first tab which isn't closed or disabled if the selected tab is closed.

this works fine for any tab but the first one.

image

primeng/src/app/components/tabview/tabview.ts

Line 763 in 1f6c5d9

tab.closed = true;

Closing the active tab after the "new" active tab is selected leads to a non active tab when the first tab is closed.

simple solution is to close the tab first before selecting a new tab

Environment

https://stackblitz.com/edit/github-2c62mz?file=src%2Fapp%2Fapp.component.html

Reproducer

https://stackblitz.com/edit/github-2c62mz?file=src%2Fapp%2Fapp.component.html

Angular version

18.2.1

PrimeNG version

17.18.9

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.11.1

Browser(s)

No response

Steps to reproduce the behavior

  1. Go to https://stackblitz.com/edit/github-2c62mz?file=src%2Fapp%2Fapp.component.html
  2. close the first tab of the tabview

Expected behavior

the second tab (Header II) should be selected
@DbkMG DbkMG added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 30, 2024
Rahul1582 added a commit to Rahul1582/primeng that referenced this issue Oct 12, 2024
@Rahul1582
fixed issue primefaces#16313
4ac8498
Rahul1582 added a commit to Rahul1582/primeng that referenced this issue Oct 12, 2024
@Rahul1582
fixed issue primefaces#16313
562116d
@Rahul1582 Rahul1582 mentioned this issue Oct 12, 2024
Merged
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 18, 2024
@mertsincan mertsincan added this to the 17.18.13 milestone Nov 18, 2024
@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Dec 9, 2024
mertsincan pushed a commit that referenced this issue Dec 9, 2024
@Rahul1582
fixed issue #16313 (p-tabview closing active first tab opens not the …
01c332f 
…next tab) (#16531)

* fixed issue #16313

* code formated
@github-project-automation github-project-automation bot moved this to Done in PrimeNG Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mehmetcetin01140 mehmetcetin01140

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
PrimeNG
Status: Done
Milestone
17.18.13
Development

Successfully merging a pull request may close this issue.

fixed issue #16313 (p-tabview closing active first tab opens not the next tab) Rahul1582/primeng
3 participants
@mertsincan @mehmetcetin01140 @DbkMG