Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component: Calendar #16686

Closed
paweell5808 opened this issue Nov 4, 2024 · 5 comments · Fixed by #16894
Closed

Component: Calendar #16686

paweell5808 opened this issue Nov 4, 2024 · 5 comments · Fixed by #16894
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.18.13

Comments

@paweell5808
Copy link

Describe the bug

The date attribute ‘data-date’ contains an incorrect value for the month; it should be 11 instead of 10. The error is due to the month values being counted from 0 instead of 1.

Environment

Angular 17, Google Chrome v130.0.6723.92

Reproducer

No response

Angular version

17.3.11

PrimeNG version

17.17.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.15.0

Browser(s)

Google Chrome v130.0.6723.92

Steps to reproduce the behavior

Zrzut ekranu 2024-11-04 104646

Expected behavior

No response
@paweell5808 paweell5808 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 4, 2024
pointers-enjoyer added a commit to pointers-enjoyer/primeng-fork that referenced this issue Nov 4, 2024
@pointers-enjoyer
primefaces#16686 fix: incorrect month value in Calendar component
3192fbe
@pointers-enjoyer pointers-enjoyer mentioned this issue Nov 4, 2024
Merged
pointers-enjoyer added a commit to pointers-enjoyer/primeng-fork that referenced this issue Nov 4, 2024
@pointers-enjoyer
Revert "primefaces#16686 fix: incorrect month value in Calendar compo…
59b0d27 
…nent"

This reverts commit 3192fbe.
@mertsincan
Copy link
Member

Is this issue fixed?

@mertsincan mertsincan added Resolution: Needs More Information More information about the issue is needed to find a correct solution and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 19, 2024
@github-actions GitHub Actions
Copy link

More information is needed to find a solution. A runnable StackBlitz example and additional details would be helpful.

@paweell5808
Copy link
Author

I checked on StackBlitz with latest version 17.18.12 and it still doesn't work.

image

@pointers-enjoyer
Copy link
Contributor

pointers-enjoyer commented Nov 26, 2024 •
edited
Loading

After I searched source code for 17.18.12, it seems a commit has passed that reverted my solution.
Commit: 59b0d27

This commit was created after I have pushed solution for this issue, on another issue branch (https://github.com/primefaces/primeng/pull/16690/commits)

Should I push this again?

@pointers-enjoyer pointers-enjoyer mentioned this issue Nov 30, 2024
Merged
@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Resolution: Needs More Information More information about the issue is needed to find a correct solution labels Dec 6, 2024
@mertsincan mertsincan added this to the 17.18.13 milestone Dec 6, 2024
@mertsincan mertsincan linked a pull request Dec 6, 2024 that will close this issue
re-fix( #16686): incorrect month value in Calendar component #16894
Merged
@mertsincan mertsincan moved this to Review in PrimeNG Dec 7, 2024
@mertsincan mertsincan moved this from Review to Done in PrimeNG Dec 9, 2024
@paweell5808
Copy link
Author

Please keep in mind to also implement this fix in higher versions, e.g. 18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
PrimeNG
Status: Done
Milestone
17.18.13
Development

Successfully merging a pull request may close this issue.

re-fix( #16686): incorrect month value in Calendar component pointers-enjoyer/primeng-fork
3 participants
@mertsincan @paweell5808 @pointers-enjoyer