Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown: does not respect emitEvent false #16755

Closed
andrii-dymov opened this issue Nov 15, 2024 · 1 comment · Fixed by #16816
Closed

Dropdown: does not respect emitEvent false #16755

andrii-dymov opened this issue Nov 15, 2024 · 1 comment · Fixed by #16816
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
17.18.13

Comments

@andrii-dymov
Copy link

Describe the bug

Dropdown component emits value change event for it's corresponding control even so there is emitEvent: false parameter when I call setValue. It happens only if control has no initial value or it's value is null. Not sure if other components have the same issue.
It looks like conditions in allowModelChange method should be updated to fix this.
image

Environment

stackblitz

Reproducer

https://stackblitz.com/edit/stackblitz-starters-7jmis4?file=src%2Fmain.ts

Angular version

18.1.0

PrimeNG version

18.0.0-beta.4

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.20.3

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@andrii-dymov andrii-dymov added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 15, 2024
@mertsincan mertsincan added Resolution: Help Wanted Issue or pull request requires extra help and feedback and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 19, 2024
@mertsincan mertsincan added this to the Future milestone Nov 19, 2024
@github-actions GitHub Actions
Copy link

Due to PrimeNG team's busy roadmap, this issue is available for anyone to work on. Make sure to reference this issue in your pull request. ✨ Thank you for your contribution! ✨

mateuszstudentzero added a commit to mateuszstudentzero/primeng-zio that referenced this issue Nov 22, 2024
@mateuszstudentzero
Fix: Dropdown respects emitEvent=false when setting value (primefaces…
421ad63 
…#16755)
@mateuszstudentzero mateuszstudentzero mentioned this issue Nov 22, 2024
Merged
@mertsincan mertsincan linked a pull request Nov 22, 2024 that will close this issue
Fix:16755 - dropdown emit event #16816
Merged
@mertsincan mertsincan modified the milestones: Future, 17.18.13 Nov 22, 2024
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Resolution: Help Wanted Issue or pull request requires extra help and feedback labels Nov 22, 2024
@mertsincan mertsincan added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Dec 6, 2024
mertsincan pushed a commit that referenced this issue Dec 6, 2024
@mateuszstudentzero @joaanyk
Fix:16755 - dropdown emit event (#16816)
eea7723 
* Create npm-grunt.yml

Do ewentualnej modyfikacji w przyszłości

* create an index.html file

* Update index.html

* Update index.html

* Fix: Add ripple effect to AccordionTab header

* Restore index.html

* Fix: Dropdown respects emitEvent=false when setting value (#16755)

* Drop uneccessary changes

---------

Co-authored-by: joaanyk <[email protected]>
@github-project-automation github-project-automation bot moved this to Done in PrimeNG Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
PrimeNG
Status: Done
Milestone
17.18.13
Development

Successfully merging a pull request may close this issue.

Fix:16755 - dropdown emit event mateuszstudentzero/primeng-zio
2 participants
@andrii-dymov @mertsincan