Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component: pInputText size attribute (18.0.0-rc.1) #16761

Closed
mazerdeci opened this issue Nov 15, 2024 · 1 comment
Closed

Component: pInputText size attribute (18.0.0-rc.1) #16761

mazerdeci opened this issue Nov 15, 2024 · 1 comment
Assignees
@cetincakiroglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
18.0.0.Final

Comments

@mazerdeci
Copy link

Describe the bug

The pInputText directive now has a size attribute. This attribute conflicts with the size attribute of the input element.

Angular compiler says Type '"10"' is not assignable to type '"small" | "large"'.

Note: You can replace size with Size to make the application compile. But this is not the right approach.

Environment

Windows 11

Reproducer

No response

Angular version

18.2.12

PrimeNG version

18.0.0-rc.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

22.11.0

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@mazerdeci mazerdeci added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 15, 2024
@mertsincan mertsincan added this to the 18.0.0-rc.2 milestone Nov 19, 2024
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 19, 2024
@mertsincan mertsincan removed this from PrimeNG Nov 20, 2024
@cetincakiroglu cetincakiroglu mentioned this issue Dec 5, 2024
Closed
cetincakiroglu added a commit that referenced this issue Dec 5, 2024
@cetincakiroglu
Rename size as pSize, fixes #16949, fixes #16761
8f8b5f8
@cetincakiroglu
Copy link
Contributor

fixed in 8f8b5f8

@github-project-automation github-project-automation bot moved this from Discussion to Done in PrimeNG Dec 5, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cetincakiroglu cetincakiroglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
PrimeNG
Status: Done
Milestone
18.0.0.Final
Development

No branches or pull requests
5 participants
@cagataycivici @mazerdeci @mertsincan @cetincakiroglu @mehmetcetin01140