Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better compatability with CSS libraries like Tailwind, Bootstrap #16809

Closed
cagataycivici opened this issue Nov 21, 2024 · 0 comments
Closed

Better compatability with CSS libraries like Tailwind, Bootstrap #16809

cagataycivici opened this issue Nov 21, 2024 · 0 comments
Assignees
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@cagataycivici
Copy link
Member

CSS libraries mainly use reset css that has an effect on PrimeVue CSS like, we should add the following for better compate;

Box-sizing for Pseudo
Tailwind and Bootstrap adds box-sizing to before and after as well, we only have it for *.

*,
::before,
::after {
    box-sizing: border-box;
}

line-height
For now, we can treat line-height as font-family, where PrimeVue components retrieve it from the document setting since it is inherited. In the future we can add a line-height token. Tailwind and Bootstrap set it as 1.5 which may break some components.

@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Nov 21, 2024
@cagataycivici cagataycivici added this to the 18.0.0-rc.2 milestone Nov 21, 2024
@cagataycivici cagataycivici self-assigned this Nov 21, 2024
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 21, 2024
@cagataycivici cagataycivici changed the title Better compat with CSS libraires like Tailwind, Bootstrap Better compatability with CSS libraries like Tailwind, Bootstrap Nov 21, 2024
@github-project-automation github-project-automation bot moved this to Done in PrimeNG Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
Status: Done
Development

No branches or pull requests

1 participant