Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component: Dropdown virtualScroll filter bug #16954

Closed
d4u3r0nl1n3 opened this issue Dec 5, 2024 · 0 comments · Fixed by #16979
Closed

Component: Dropdown virtualScroll filter bug #16954

d4u3r0nl1n3 opened this issue Dec 5, 2024 · 0 comments · Fixed by #16979
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.18.13

Comments

@d4u3r0nl1n3
Copy link

d4u3r0nl1n3 commented Dec 5, 2024 •
edited
Loading

Describe the bug

p-scroller doesn't update the initial scroll after clearing filters.
only happens when using filter="true" and virtualScroll="true" in combination

image

After clearing the filter again:

image

Environment

Angular: 19.0.0
PrimeNG: 17.18.12

Reproducer

https://stackblitz.com/edit/pkujrn?file=package.json

Angular version

19.0.0

PrimeNG version

17.18.12

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.12.2

Browser(s)

Chrome

Steps to reproduce the behavior

  1. Go to https://stackblitz.com/edit/pkujrn?file=package.json
  2. Open dropdown (p-scroller > div has style "height: 200px")
  3. Filter for "abc"
  4. The result preview shows "No results found" empty message (p-scroller > div has style "height: 59px")
  5. Remove the filtered value ("abc")
  6. The initial result list is displayed but the height is not updated / changed back to initial (200px)

Expected behavior

After clearing the filtered value the height of the p-scroller > div should adjust back to the inital state (200px)
@d4u3r0nl1n3 d4u3r0nl1n3 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 5, 2024
@joaanyk joaanyk mentioned this issue Dec 7, 2024
Merged
@mertsincan mertsincan added this to the 17.18.13 milestone Dec 9, 2024
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Dec 9, 2024
@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add labels Dec 9, 2024
mertsincan pushed a commit that referenced this issue Dec 9, 2024
@joaanyk @mateuszstudentzero
Fix: Ensure p-scroller updates height after clearing filters (#16954) (…
5ce92d2 
…#16979)

* Create npm-grunt.yml

Do ewentualnej modyfikacji w przyszłości

* create an index.html file

* Update index.html

* Update index.html

* Fix: Improve dynamic styling for avatar component

* Remove unnecessary files

* Fix dropdown virtual scroll filter bug

* Restore changes for previous issue

* Restore changes for previous issu

---------

Co-authored-by: Mateusz Adamczyk <[email protected]>
Co-authored-by: mateuszstudentzero <[email protected]>
@github-project-automation github-project-automation bot moved this from Review to Done in PrimeNG Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
PrimeNG
Status: Done
Milestone
17.18.13
Development

Successfully merging a pull request may close this issue.

Fix: Ensure p-scroller updates height after clearing filters (#16954) mateuszstudentzero/primeng-zio
2 participants
@mertsincan @d4u3r0nl1n3