-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component: Paginator. "Show All" option in dropdown always displayed first #17068
Comments
Due to PrimeNG team's busy roadmap, this issue is available for anyone to work on. Make sure to reference this issue in your pull request. ✨ Thank you for your contribution! ✨ |
@mertsincan New implementation is not what I would expect either. What if I want to display the "ALL" button first? I cannot do that anymore... Instead of pushing it as last argument, is it possible to simply push all items in the same order? |
That way users determine the order of the elements. example 1: Example 3 is less likely to happen, however possible with easy change of implementation. |
Describe the bug
When you use paginator with
rowsPerPageOptions
property you can display "All" option. However, it will always be displayed first even if you define it as last inrowsPerPageOptions
.I would expect that the following snippet would result in 'All' option displayed last in dropdown.
You could probably simply not do unshift but just push 'All' option whenever someone puts it in
rowsPerPageOptions
- https://github.com/primefaces/primeng/blob/master/src/app/components/paginator/paginator.ts#L409Environment
stackblitz
Reproducer
https://stackblitz.com/edit/stackblitz-starters-t6faqdch?file=src%2Fapp%2Fapp.component.html
Angular version
^18.2.0
PrimeNG version
^18.0.0
Build / Runtime
Angular CLI App
Language
TypeScript
Node version (for AoT issues node --version)
stackblitz
Browser(s)
No response
Steps to reproduce the behavior
No response
Expected behavior
No response
The text was updated successfully, but these errors were encountered: