Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown/Select: Marked as dirty immediately, if no placeholder is set #17178

Closed
4 tasks
johanneszelger opened this issue Dec 22, 2024 · 0 comments · Fixed by #17179
Closed
4 tasks

Dropdown/Select: Marked as dirty immediately, if no placeholder is set #17178

johanneszelger opened this issue Dec 22, 2024 · 0 comments · Fixed by #17179
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
19.0.2

Comments

@johanneszelger
Copy link
Contributor

Describe the bug

When no placeholder is set, for example when using floatlabel, the dropdown is dirty immediately upon loading.

Pull Request Link

No response

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

See stackblity of select with float label in official documentation

Environment

Check official documentation select with floatlabel

Angular version

latest

PrimeNG version

v19

Node version

No response

Browser(s)

No response

Steps to reproduce the behavior

  • Open the stackblitz of select+float label
  • Remove the placeholder
  • Add any validator like required
  • reload the page
  • immedately the dropdown will be "red" as it is invalid and dirty

Expected behavior

Should not be dirty before being edited.
@johanneszelger johanneszelger added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 22, 2024
@mark7p mark7p mentioned this issue Dec 22, 2024
Merged
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 23, 2024
@mertsincan mertsincan added this to the 19.0.2 milestone Dec 23, 2024
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Dec 23, 2024
cetincakiroglu added a commit that referenced this issue Dec 23, 2024
@cetincakiroglu
Merge pull request #17179 from mark7p/fix/#17178-select-marked-dirty-…
865f4ba 
…on-start

Fix: Dropdown/Select(#17178) Marked as dirty on start
@github-project-automation github-project-automation bot moved this from Review to Done in PrimeNG Dec 23, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
PrimeNG
Status: Done
Milestone
19.0.2
Development

Successfully merging a pull request may close this issue.

Fix: Dropdown/Select(#17178) Marked as dirty on start mark7p/primeng
3 participants
@mertsincan @johanneszelger @cetincakiroglu