Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v19 DynamicDialog: Rendering problem when displaying Dynamic Dialog content without fix #17193

Closed
1 of 4 tasks
rosenthalj opened this issue Dec 23, 2024 · 0 comments · Fixed by #17194
Closed
1 of 4 tasks
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@rosenthalj
Copy link
Contributor

Describe the bug

PrimeNG's Dynamic Dialog fails to display content that doesn't have a fixed height.

The first video shows how the Dynamic Dialog fails to display a simple div (100% height and 100% width and red background)

DynamicDialogBad.mov

The second video shows v17 PrimeNG using the exact same program and the Dynamic Dialog working correctly

DynamicDialogGood.mov

Pull Request Link

No response

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

tbd - but this is a valid issue

Reproducer

https://stackblitz.com/edit/vyyhpncb?file=src%2Fapp%2Fdemo%2Fproductlistdemo.ts,src%2Fapp%2Fimports.ts,src%2Fapp%2Fdynamic-dialog-example-demo.ts,src%2Fapp%2Fdemo%2Ffooter.ts,src%2Fapp%2Fdynamic-dialog-example-demo.html

Environment

n/a

Angular version

19

PrimeNG version

v19

Node version

n/a

Browser(s)

All

Steps to reproduce the behavior

  1. Run the reproducer: https://stackblitz.com/edit/vyyhpncb?file=src%2Fapp%2Fdemo%2Fproductlistdemo.ts,src%2Fapp%2Fimports.ts,src%2Fapp%2Fdynamic-dialog-example-demo.ts,src%2Fapp%2Fdemo%2Ffooter.ts,src%2Fapp%2Fdynamic-dialog-example-demo.html
  2. Click on the "Launch" button
  3. A Dynamic Dialog will be displayed
    -- Dialog will be the correct height and width
    -- Red div in the center of the dialog will be missing

Expected behavior

Run the same program with this v17 reproducer: https://stackblitz.com/edit/a9zz8skp?file=src%2Fapp%2Fdynamic-dialog-example-demo.ts,src%2Fapp%2Fdemo%2Fproductlistdemo.ts,src%2Fapp%2Fdynamic-dialog-example-demo.html,src%2Fapp%2Fimports.ts

After pressing the "Launch" button the Dynamic Dialog will be displayed
-- Dialog will be the correct height and width
-- A Red div in the center of the dialog will be displayed

@rosenthalj rosenthalj added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 23, 2024
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 25, 2024
@mertsincan mertsincan added this to the 19.0.2 milestone Dec 25, 2024
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Dec 25, 2024
@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Dec 25, 2024
@mertsincan mertsincan linked a pull request Dec 25, 2024 that will close this issue
mertsincan pushed a commit that referenced this issue Dec 25, 2024
* fixed rendering of dynamic dialog content

* Update dialogstyle.ts

to be consistent with previous versions of PrimeNG changed flex: 1 1 auto to flex-grow: 1
@github-project-automation github-project-automation bot moved this from Review to Done in PrimeNG Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants